Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Conversation

@alkino
Copy link
Member

@alkino alkino commented Aug 24, 2022

Usa last version of hpc-coding-conv

@olupton
Copy link
Contributor

olupton commented Aug 24, 2022

We need to translate this:

# Adds .cu with respect to the current default in hpc-coding-conventions, and drops various patterns
# that don't match anything in CoreNEURON.
set(CORENRN_ClangFormat_FILES_RE
"^.*\\\\.cu$$" "^.*\\\\.h$$" "^.*\\\\.[chi]pp$$"
CACHE STRING "List of regular expressions matching C/C++ filenames" FORCE)
set(CORENRN_ClangFormat_EXCLUDES_RE
""
CACHE STRING "list of regular expressions to exclude C/C++ files from formatting" FORCE)
set(CORENRN_CMakeFormat_EXCLUDES_RE
"CMake/packages/.*$$"
CACHE STRING "list of regular expressions to exclude CMake files from formatting" FORCE)
for the new hpc-coding-conventions.

For the single Python file, I guess we can just commit the updated version.

Nicolas Cornu and others added 7 commits August 24, 2022 15:46
@alkino alkino changed the title Bump CoreNeuron and hpc-coding-conventions Use last hpc-coding-conventions formatter script Aug 24, 2022
@alkino alkino closed this Aug 24, 2022
@alkino alkino reopened this Aug 24, 2022
Copy link
Collaborator

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me!

@alkino alkino merged commit d6507e2 into master Aug 25, 2022
@alkino alkino deleted the bump_deps branch August 25, 2022 05:53
pramodk pushed a commit to neuronsimulator/nrn that referenced this pull request Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants