This repository was archived by the owner on Jun 8, 2023. It is now read-only.
Remove omp atomic update and critical #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pramodk
reviewed
Feb 14, 2023
pramodk
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Feb 15, 2023
* use of omp atomic is unnecessary - avoid compilation error with NVHPC 21.1 * see BlueBrain/mod2c/pull/90
1 task
olupton
approved these changes
Feb 15, 2023
Collaborator
|
I launched neuron wheel testing CI: https://bbpgitlab.epfl.ch/hpc/cellular/neuron-gpu-wheel-testing/-/jobs/555371 |
Collaborator
|
I was bit confused by wheel testing CI failing with Azure Drop but it seems unrelated: neuronsimulator/nrn#2227 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take number 2 on #89 .
Having
with OpenMP and GPU/OpenACC enabled with
mod2cgenerates the following issue:For this purpose
#pragma omp atomic updatecan be removed since we never have#pragma omp simdinmod2cand#pragma ivdepis disabled when we have eitherPROTECT,MUTEXorMUTEUNLOCK.For the same reason I think
#pragma omp criticalcan also be removed.