Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Conversation

@joni-herttuainen
Copy link
Contributor

No description provided.

Copy link
Contributor Author

@joni-herttuainen joni-herttuainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GianlucaFicarelli Tell me what you think. If this looks somewhat ok, I'll update the docs and add changelog entries. Should we bump this up a major version bearing in mind we will also change {nodes,edges}.get?

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2023

Codecov Report

Merging #213 (dfeb452) into master (2da1c6d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #213   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         2163      2159    -4     
=========================================
- Hits          2163      2159    -4     
Flag Coverage Δ
pytest 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bluepysnap/circuit.py 100.00% <100.00%> (ø)
bluepysnap/frame_report.py 100.00% <100.00%> (ø)
bluepysnap/node_sets.py 100.00% <100.00%> (ø)
bluepysnap/nodes/node_population.py 100.00% <100.00%> (ø)
bluepysnap/simulation.py 100.00% <100.00%> (ø)

@mgeplf
Copy link
Contributor

mgeplf commented Jun 20, 2023

Things look reasonable to me, but I haven't been following it as closely as @GianlucaFicarelli - IMO he should have the final say.

Copy link
Contributor

@GianlucaFicarelli GianlucaFicarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Should we release 1.0.7 before merging and releasing 1.1.0?
Alternatively, the changelog should be updated (moving the entries from 1.0.7 to 1.1.0, after rebasing on master)

@joni-herttuainen
Copy link
Contributor Author

I'm happy with merging and releasing any none-breaking changes first

@GianlucaFicarelli
Copy link
Contributor

I'm happy with merging and releasing any none-breaking changes first

I'd like to merge #220 once it's approved (since it's not a breaking change), release 1.0.7, then merge this PR and release 1.1.0. What do you think?

@joni-herttuainen
Copy link
Contributor Author

Sounds good. I think #220 is good to go.

Copy link
Contributor

@GianlucaFicarelli GianlucaFicarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joni-herttuainen joni-herttuainen merged commit 92e9c84 into master Jun 26, 2023
@joni-herttuainen joni-herttuainen deleted the libsonata_nodeset branch June 26, 2023 10:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants