Fix image layout transition in 'pick' pass#111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current 'pick' implementation uses an image barrier before the copy command, which transfers the rendered image from
VK_IMAGE_LAYOUT_UNDEFINEDtoVK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL. According to vk spec, doing so will cause the contents of the image’s memory to be undefined. The expectedoldLayoutisVK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMALspecified in thefinalLayoutfield of subpass description.Similarly, an earlier barrier transfers the image's layout from
VK_IMAGE_LAYOUT_UNDEFINEDtoVK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL. This transition is presented again in the renderpass description.This commit fixes #42 by correcting these layout values.