fix first person camera lookatMat#334
Merged
Merged
Conversation
Collaborator
|
Thank you very much for contributing to Piccolo! We'll arrange reviewing and testing soon. |
Ol6rin
approved these changes
Sep 9, 2022
Ol6rin
pushed a commit
that referenced
this pull request
Sep 10, 2022
KaygNas
pushed a commit
to KaygNas/Piccolo
that referenced
this pull request
Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I try to add a function about switch to first-person-view，I found the lookAt Matrix use wrong parameter. So I fixed it.
Besides I also have a try the first person vertical offset and found its position may not reasonable, which is 0.6. Thus the first-person-view was build on the legs of the character.
What's more, The engine uses rotation dirty flag to update character orientation. In the third-person-view it works well and save resource but it seems a little strange in the first-person-view.