Skip to content

Adjust notification HotKeyTab #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 25, 2017
Merged

Adjust notification HotKeyTab #1010

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
80283b5
Adjust notification HotKeyTab
PaulRosset Oct 24, 2017
c0368ce
correction
PaulRosset Oct 24, 2017
bd013ad
correction eslint syntax
PaulRosset Oct 24, 2017
d23156d
Correction build error
PaulRosset Oct 24, 2017
1c02b4e
Delete setTimeout() due to problem wih test
PaulRosset Oct 24, 2017
c97c65b
Delete clearMessage due to problem wih test [WIP]
PaulRosset Oct 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Delete setTimeout() due to problem wih test
  • Loading branch information
@PaulRosset
PaulRosset committed Oct 24, 2017
commit 1c02b4e62a2ac75125b89eabb1a8f13731dbe7b9
11 changes: 5 additions & 6 deletions browser/main/modals/PreferencesModal/HotkeyTab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,6 @@ class HotkeyTab extends React.Component {
type: 'SET_UI',
config: newConfig
})

setTimeout(() => {
this.setState({
keymapAlert: null
})
}, 2000)
}

handleHintToggleButtonClick (e) {
Expand All @@ -75,6 +69,11 @@ class HotkeyTab extends React.Component {
})
}

componentWillUnmount () {
console.log("YAYA")
clearTimeout(this.timer)
}

render () {
let keymapAlert = this.state.keymapAlert
let keymapAlertElement = keymapAlert != null
Expand Down