Skip to content

Conversation

@asmsuechan
Copy link
Contributor

context

As @piefel mentioned in #1009 (comment), it's not easy to understand the role of the lock button. So I changed the tooltip text.

before

image

image

after

image

image

@BoostnoteBot
Copy link
Collaborator

Be sure to be changed browser/main/Detail/SnippetNoteDetail.js.

@kazup01 kazup01 self-requested a review October 26, 2017 04:49
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit 7549a7b into BoostIO:master Oct 26, 2017
@kazup01
Copy link
Member

kazup01 commented Oct 26, 2017

Thanks @asmsuechan !

@asmsuechan asmsuechan deleted the improve-lock-tooltip-text branch October 26, 2017 05:44
@asmsuechan
Copy link
Contributor Author

I ignored the BoostBot's comment (#1014 (comment)) because the lock button is not implemented in snippet notes.

@kohei-takata kohei-takata mentioned this pull request Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants