Add trash can #297
Merged
Add trash can #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazup01
added
the
awaiting changes 🖊️
Contributor
Author
|
Must improve: Undo UI |
asmsuechan
commented
Jun 28, 2017
| </button> | ||
|
|
||
| // TODO: must refactor | ||
| const menuBar = location.pathname === '/trashed' |
Contributor
Author
There was a problem hiding this comment.
Obviously, this code is dirty. So I assume I have to make some new components for it.
asmsuechan
removed
the
awaiting changes 🖊️
Contributor
Author
|
Escape from deletion when a user is in the trashed. |
Contributor
Author
|
ref: #263 |
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added trash can as well as the star.
TODO:
add migrater likebrowser/main/lib/dataApi/migrateFromV6Storage.js