Feature rearrange storage

[PrimaMateria]

Hi guys,
this is my first contribution to other github project and also first time I worked with react, so please be critical.
It is related to issue Rearrange storage #741.

Quick description:
From StorageItem extracted FolderList and FolderItem as separate components.
Wrapped them in the rect-sortable-hoc.
Implemented new data api method called reorderFolder.

I hope you will like it.
Cheers
Matus

[BoostnoteBot]

Please make sure to be pasted screenshots of all your changes.

[kazup01]

Firstly, could you fix the CI error?

[PrimaMateria]

Here comes the screenshot:

Ok, I will later have look on the failed checks.

[asmsuechan]

Can you use findStorage()? https://github.com/BoostIO/Boostnote/blob/master/browser/lib/findStorage.js

[PrimaMateria]

Why is findStorage in browser/lib and not in browser/main/lib/dataApi?
Besides my reorderFolder I also updated updateFolder.
There was one more possible candidate renameStorage, but I didn't want to touch it now in the scope of this issue.

[asmsuechan]

Because it just operates localStorage, does not operate files.

[asmsuechan]

Good 😄

[PrimaMateria]

Tests are failing randomly. I put log into beforeEach and after for reorderFolder-test and moveNote-test and it seems like one test is clearing localStorage during the execution of other.

This is log from the failed run:

reorderFolder setting items to localStorage
moveNote setting items to localStorage
moveNote clearing localStorage

   19 passed
   1 failed


   1. dataApi › reorderFolder-test › Reorder a folder
   failed with "Cannot read property 'key' of undefined"
      Test.fn (reorderFolder-test.js:43:58)
    _combinedTickCallback (internal/process/next_tick.js:141:11)
    process._tickCallback (internal/process/next_tick.js:180:9)

And these are 2 logs from successful run:

reorderFolder setting items to localStorage
/tmp/test/reorder-folder/boostnote.json
moveNote setting items to localStorage
reorderFolder clearing localStorage
/tmp/test/update-folder/boostnote.json
/tmp/test/create-folder/boostnote.json
moveNote clearing localStorage

/tmp/test/create-folder/boostnote.json
reorderFolder setting items to localStorage
/tmp/test/update-folder/boostnote.json
/tmp/test/reorder-folder/boostnote.json
reorderFolder clearing localStorage
moveNote setting items to localStorage
moveNote clearing localStorage

You can see that order is always different.

[asmsuechan]

Tests are failing randomly.

I know it. But The fixing cost >>>>>> Push the restart button.

[PrimaMateria]

Hi guys, I am sorry, I don't know how the process works now.
Is there something left for me to do?

[asmsuechan]

Is there something left for me to do?

No, there's nothing to say about your PR. I left cross-OS checks for my review but I'm busy in these days so I could not take a time to do it. I'll work on this PR again in a week.

[asmsuechan]

Works fine! Thank you!

[kazup01]

Hi @PrimaMateria , I wrote about this PR in my article. Check it! https://medium.com/boostnote/thanks-to-your-contribution-boostnote-v0-8-16-has-been-released-783afea95ca3