Skip to content

Conversation

@asmsuechan
Copy link
Contributor

context

We want users to notify tips.

before

after

image

note

I'm not sure how I describe plural notifications, so I managed to show the first notification of them notifications[0]

For tests

  • it should not fail the application even if the notification repository does not exist
  • it should show a notification

@BoostnoteBot
Copy link
Collaborator

Please make sure to be pasted screenshots of all your changes.

@kazup01
Copy link
Member

kazup01 commented Sep 20, 2017

🎉

Copy link
Contributor

@kohei-takata kohei-takata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kohei-takata kohei-takata merged commit c762b9a into BoostIO:master Sep 22, 2017
@kazup01 kazup01 mentioned this pull request Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants