Skip to content

Conversation

@asmsuechan
Copy link
Contributor

@asmsuechan asmsuechan commented Sep 22, 2017

context

We want to exit from the editor in Vim mode.

before

02a6570e0dd85231d3120aa861a95a83

after

f76f1b74be813ee10f631b1cd41486d0

For test

  • :q exits from editor mode
  • :q! exits from editor mode
  • :qw exits from editor mode

@kazup01
Copy link
Member

kazup01 commented Sep 22, 2017

awesome

@KLszTsu
Copy link
Contributor

KLszTsu commented Sep 22, 2017

May I ask if :wq (Save and Exit) works either?
I know it don't need to be saved manually but saving is a habit for people like me.

Thanks.

@asmsuechan
Copy link
Contributor Author

asmsuechan commented Sep 22, 2017

Sadly it doesn't work because of https://github.com/codemirror/CodeMirror/blob/25e12b5fe1ee7b0be7e7ee4306608caa4e93c6d6/keymap/vim.js#L701.
It means only 1 key is allowed to be defined as my own command.

I misunderstood. I can.

@KLszTsu
Copy link
Contributor

KLszTsu commented Sep 22, 2017

Thanks very much anyway.

@KLszTsu
Copy link
Contributor

KLszTsu commented Sep 22, 2017

(It should be :wq instead :qw.)

@asmsuechan
Copy link
Contributor Author

Exactly 😆

@kazup01 kazup01 merged commit bd266dc into BoostIO:master Sep 23, 2017
@kazup01 kazup01 mentioned this pull request Sep 23, 2017
@asmsuechan asmsuechan deleted the exit-by-comma-q-in-vim-mode branch September 30, 2017 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants