Allow users to disable "Saved to clipboard" notification. #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fixed the travis build, let me know if you have any questions. Hopefully this gets merged in to the next release, I would love to start using this feature. |
Member
|
Thanks @urda ! We will check it. |
Contributor
Author
|
Great! Thanks for an awesome note taking app! |
Member
|
Thanks for your cooperation, too :) |
Contributor
Author
|
Re-sync'ing with |
asmsuechan
approved these changes
Oct 1, 2017
Contributor
asmsuechan
left a comment
asmsuechan
left a comment
There was a problem hiding this comment.
Works fine on macOS and ubuntu. Thanks!
Contributor
Author
|
Thanks! Can’t wait to see it released :) |
Merged
Member
Member
|
Hi @urda , I wrote about this PR in my article :) Check it! https://medium.com/boostnote/thanks-to-your-contribution-boostnote-v0-8-16-has-been-released-783afea95ca3 |
Contributor
Author
|
Sounds good @kazup01 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I love the "copy to clipboard" power of Boostnote within code blocks. However, as an end user, I don't really care for Boostnote to display a notification on copy.
This PR adds a configuration option to disable these notifications! The new option is show below
This is my first PR to Boostnote, please let me know if this commit needs amended.