Improve searching #954
Merged
Improve searching #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmsuechan
commented
Oct 12, 2017
browser/main/TopBar/index.js
Outdated
| }) | ||
|
|
||
| // When the key is an alphabet, del, enter or ctr | ||
| if (e.keyCode <= 90) { |
Contributor
Author
There was a problem hiding this comment.
This does not work on various keyCodes... Need to change.
German: üöä
French: ù
Spanish: ñ
Russian: (work fine)
Chinese: (work fine by using pinyin keyboard)
Contributor
Author
There was a problem hiding this comment.
I decided to extend the keyCode scope to e.keyCode<=90 || 186<=e.keyCode<=222 according to http://www.javascripter.net/faq/keycodes.htm.
This was referenced Oct 13, 2017
Contributor
Author
current specificationsThere are some unclear points.
|
|
chinese input has same problem |
Contributor
Author
|
@lyrl I know it. I have a question regarding Chinese keyboard. Is pinyin keyboard used by much Chinese?
|
|
@asmsuechan SouGou pinyin is most popular in china! http://pinyin.sogou.com/ |
Contributor
Author
|
@lyrl 谢谢你告诉我！I switched from Google pinyin keyboard to SouGou. |
Contributor
|
Btw, under Linux, most Chinese people will choose fcitx. |
Merged
bimlas
added a commit
to bimlas/Boostnote
that referenced
this pull request
Mar 20, 2018
Some issues introduced in BoostIO#954 (BoostIO#954 (comment)): - search by `#tag1 #tag2` returns the results of only `#tag2` - search by `#tag1 content` is as same as AND search by `#tag1 content` (and `#tag1` is regarded a word, not a tag) - search by `content #tag1` returns the results of only `#tag1` This commit fixing these: - search by `#tag1 #tag2` returns the results of only `#tag2` ![screencast]() - search by `#tag1 content` is as same as AND search by `#tag1 content` (and `#tag1` is regarded a word, not a tag) ![screencast]() - search by `content #tag1` returns the results of only `#tag1` ![screencast]()
bimlas
added a commit
to bimlas/Boostnote
that referenced
this pull request
Mar 20, 2018
Some issues introduced in BoostIO#954 (BoostIO#954 (comment)): - search by `#tag1 #tag2` returns the results of only `#tag2` - search by `#tag1 content` is as same as AND search by `#tag1 content` (and `#tag1` is regarded a word, not a tag) - search by `content #tag1` returns the results of only `#tag1` This commit fixing these: - search by `#tag1 #tag2` returns the results of only `#tag2`  - search by `#tag1 content` is as same as AND search by `#tag1 content` (and `#tag1` is regarded a word, not a tag)  - search by `content #tag1` returns the results of only `#tag1`  NOTE: the examples works without `#` character too, because `findByWord()` checks the tags too.
bimlas
added a commit
to bimlas/Boostnote
that referenced
this pull request
Mar 20, 2018
Some issues introduced in BoostIO#954 (BoostIO#954 (comment)): - search by `#tag1 #tag2` returns the results of only `#tag2` - search by `#tag1 content` is as same as AND search by `#tag1 content` (and `#tag1` is regarded a word, not a tag) - search by `content #tag1` returns the results of only `#tag1` This commit fixing these: - search by `#tag1 #tag2` returns the results of only `#tag2`  - search by `#tag1 content` is as same as AND search by `#tag1 content` (and `#tag1` is regarded a word, not a tag)  - search by `content #tag1` returns the results of only `#tag1`  NOTE: the examples works without `#` character too, because `findByWord()` checks the tags too.
bimlas
added a commit
to bimlas/Boostnote
that referenced
this pull request
Mar 20, 2018
Some issues introduced in BoostIO#954 (BoostIO#954 (comment)): - search by `#tag1 #tag2` returns the results of only `#tag2` - search by `#tag1 content` is as same as AND search by `#tag1 content` (and `#tag1` is regarded a word, not a tag) - search by `content #tag1` returns the results of only `#tag1` This commit fixing these: - search by `#tag1 #tag2` returns the results of only `#tag2`  - search by `#tag1 content` is as same as AND search by `#tag1 content` (and `#tag1` is regarded a word, not a tag)  - search by `content #tag1` returns the results of only `#tag1`  NOTE: the examples works without `#` character too, because `findByWord()` checks the tags too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context
This PR fixes a problem which IME doesn't work on searching.
before
after
Boostnote will support IME input (I checked working in Japanese keyboard and Chinese pin yin keyboard)