Skip to content

Fix side nav style #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 21, 2017
Merged

Fix side nav style #999

merged 8 commits into from
Oct 21, 2017

Conversation

@sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Oct 21, 2017

on v0.8.16, we added tagArea.
It cause some style bugs. I fixed these bugs.

before

When, we pushed NavToggle Button,
2017-10-21 14 34 49

  • 1: background-color of storageList is white.
  • 2: icon of PreferenceButton, AllNotesButton, StarredButton, and TrashedButton is disable.
  • 3: There is a mystery space at the top of SideNav.

after

2017-10-21 14 39 33

@BoostnoteBot
Copy link
Collaborator

BoostnoteBot commented Oct 21, 2017

Please make sure to be pasted screenshots of all your changes.

@kazup01 kazup01 self-requested a review October 21, 2017 06:03
kazup01
kazup01 approved these changes Oct 21, 2017
View reviewed changes
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit 3397b31 into master Oct 21, 2017
@kazup01 kazup01 deleted the fix-sideNav-style branch October 21, 2017 06:04
@kazup01
Copy link
Member

kazup01 commented Oct 21, 2017

Merged

@kohei-takata kohei-takata mentioned this pull request Oct 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazup01 kazup01 kazup01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sosukesuzuki @BoostnoteBot @kazup01