Decrease test memory usage by generating prefilter tests lazily #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generating all the prefilter test cases at once caused memory usage to spike up to ~7.1 GB. This lazy implementation sees ~100 MB peak.
BurntSushi
pushed a commit
that referenced
this pull request
Apr 30, 2022
Generating all the prefilter test cases at once caused memory usage to spike up to ~7.1 GB. This lazy implementation sees ~100 MB peak. More specifically, this crate always OOMs in crater due to the sandbox limits. In fact, its test suite can hit a peak memory usage of ~7.1 GB which as far as one can tell is a comfortable 2x greater than any other crate in the top 1,000 by downloads. Closes #105
BurntSushi
pushed a commit
that referenced
this pull request
Apr 30, 2022
Generating all the prefilter test cases at once caused memory usage to spike up to ~7.1 GB. This lazy implementation sees ~100 MB peak. More specifically, this crate always OOMs in crater due to the sandbox limits. In fact, its test suite can hit a peak memory usage of ~7.1 GB which as far as one can tell is a comfortable 2x greater than any other crate in the top 1,000 by downloads. Closes #105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate always OOMs in crater due to the sandbox limits. In fact, its test suite can hit a peak memory usage of ~7.1 GB which as far as I can tell is a comfortable 2x greater than any other crate in the top 1,000 by downloads.
Simply generating the test cases lazily brings the peak memory usage down to ~100 MB, much more reasonable.