Skip to content

Add an unsizing operation to {Arc,Rc}Box #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 3 commits into from
Apr 16, 2021
Merged

Add an unsizing operation to {Arc,Rc}Box #71

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91d57b8
Add unsizing for {Arc,Rc}Box
197g Apr 15, 2021
bc02b1e
Adjust documentation on unsizing
197g Apr 15, 2021
e8b7cc3
Resolve review nits in documentation
197g Apr 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust documentation on unsizing
  • Loading branch information
@197g
197g committed Apr 15, 2021
commit bc02b1e4457faaccc8fbc925009175183ec2ae25
3 changes: 3 additions & 0 deletions crates/rc-box/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,6 @@ optional = true
[dependencies.unsize]
version = "1.1"
optional = true

[package.metadata.docs.rs]
all-features = true
11 changes: 6 additions & 5 deletions crates/rc-box/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,6 @@ macro_rules! rc_box {

// ~~~ $Rc<T> and Box<T> like inherent impls ~~~ //

// downcast is pretty useless without CoerceUnsized

impl $RcBox<dyn Any + 'static> {
doc_comment! {
concat!("Attempt to downcast the box to a concrete type.
Expand All @@ -122,7 +120,8 @@ print_if_string(my_number.try_into().unwrap());
```

The unsizing as `", stringify!($Rc), "` is required until
[DST coercions](https://github.com/rust-lang/rust/issues/27732) are stabilized."),
[DST coercions](https://github.com/rust-lang/rust/issues/27732) are stabilized. Alternatively,
activate the `unsize` feature to convert the pointer via an explicit method call."),
#[inline]
pub fn downcast<T>(self) -> Result<$RcBox<T>, Self>
where T: Any,
Expand Down Expand Up @@ -164,7 +163,8 @@ print_if_string(my_number.try_into().unwrap());
```

The unsizing as `", stringify!($Rc), "` is required until
[DST coercions](https://github.com/rust-lang/rust/issues/27732) are stabilized."),
[DST coercions](https://github.com/rust-lang/rust/issues/27732) are stabilized. Alternatively,
activate the `unsize` feature to convert the pointer via an explicit method call."),
#[inline]
pub fn downcast<T>(self) -> Result<$RcBox<T>, Self>
where T: Any + Send
Expand Down Expand Up @@ -206,7 +206,8 @@ print_if_string(my_number.try_into().unwrap());
```

The unsizing as `", stringify!($Rc), "` is required until
[DST coercions](https://github.com/rust-lang/rust/issues/27732) are stabilized."),
[DST coercions](https://github.com/rust-lang/rust/issues/27732) are stabilized. Alternatively,
activate the `unsize` feature to convert the pointer via an explicit method call."),
#[inline]
pub fn downcast<T>(self) -> Result<$RcBox<T>, Self>
where T: Any + Send + Sync
Expand Down