Fix footer positioning #952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blankdots
reviewed
Feb 1, 2023
csc-felipe
force-pushed
the
bugfix/footer-login
branch
from
2e89518 to
84db6cb
Compare
blankdots
approved these changes
Feb 1, 2023
2 tasks
csc-jm
pushed a commit
that referenced
this pull request
Jun 7, 2024
Merge branch 'test/e2e-tests-december' into 'main' * Delete fixtures between tests * Add file download as part of e2e sharing test * Add test for direct archive download * Test direct file download via OPFS * Add test for archive download with service worker * Test service worker file download * Improve flaky logout command * Reset DB between tests. Reset deletes containers in swift and admin projects * Make cypress test formatting consistent * Update and reorder cypress commands * Refactor container e2e tests * Remove userInfo.cy.js old login tests, move missing to login.cy.js, refactor * Update browser tests * Check for error alert when adding a duplicate file for upload test. Unify quotation marks * Add testid to progress toast * Refactor cypress commands. Use file upload commands * Update and finish upload e2e tests. Use upload folder creation instead of deprecated upload folder search * Fix test to find a shared folder in a multi-page table * Update table sharing test, test upload to shared folder. Add share command. * Switch user instead of projects. Shorten wait time before toast * Update sharing tests, remove reliance on UI text, add project switching command * added download test * added commands * added tests * init Closes #952, #953, and #954 See merge request https://gitlab.ci.csc.fi/sds-dev/sd-connect/swift-browser-ui/-/merge_requests/236 Approved-by: Joonatan Mäkinen <[email protected]> Co-authored-by: Monika Radaviciute <[email protected]> Co-authored-by: Mariia <[email protected]> Merged by Joonatan Mäkinen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The footer positioning was inconsistent across pages. This makes it consistent, and doesn't overlap anymore.
CSC components use
flexfor positioning, and the footer overriding that, which was breaking theflexsystem.Related issues
Type of change
Changes Made
footerelement for the footerTesting
Mentions