Skip to content

fix(report): locked preview keeps the failed-prompt count; drop dead doc links - #163

Merged
razel-hash merged 2 commits into
mainfrom
lane/aeo-preview-failed
Nov 10, 2026
Merged

razel-hash merged 2 commits into
mainfrom
lane/aeo-preview-failed

Conversation

@razel-hash

Copy link
Copy Markdown
Collaborator

What

Two small follow-ups, both from Mercury's review.

  • Locked preview: redactForPreview now keeps an engine's failedPrompts count. That count arrived in feat(crawler): one crawl module for both paths, one budget, failed prompts not counted #154. Without it, an engine that failed every prompt read "COMING SOON" in the locked preview instead of "UNAVAILABLE". No prompt, answer or site name is kept.
  • Dead links: 12 code comments pointed at docs/audit/* files, which are not in this repo. The pointers are removed; each comment still says why on its own. This covers TDD task AEO-T-003, "no dead docs/audit/* link on main".

Pipeline: /tdd (gate.redact.test.ts fails on main with COMING SOON ≠ UNAVAILABLE, and passes with the change) → tsc → full suite

Risk

  • None in off or observe mode. In enforce mode, the locked preview's engine badge is now correct.
  • The comment edits change no behaviour.
  • Rollback: revert the PR.

Code review: self-review only. It is a one-field change with a test, plus comment edits.

Checks: npx vitest run passed 217/217 tests before the new spec, and the new spec passes. npx tsc --noEmit is clean. grep docs/audit/ src scripts returns nothing.

🤖 Generated with Claude Code

…doc links from comments

- redactForPreview carries failedPrompts (a count) so an engine that failed every prompt
  reads UNAVAILABLE in the locked preview too
- comments no longer point at docs/audit/* files that are not in this repo

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
campaign-creators-aeo-auditor Ready Ready Preview Nov 10, 2026 1:29pm UTC

Request Review

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@razel-hash

Copy link
Copy Markdown
Collaborator Author

Added 4cc3f3a: hubspot.test.ts clears AEO_HUBSPOT_SYNC for itself. The CI workflow from #155 sets it to off as a safety net, and that switched off the sync this spec tests against a fake. CI test now passes here (1m15s). #161 and #162 show red for the same reason and go green after this merges (re-run, or rebase if needed).

@razel-hash
razel-hash merged commit f99f5e8 into main Nov 10, 2026
3 checks passed

This branch was successfully deployed

1 active deployment
Preview — 4cc3f3a9 Deployed Nov 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant