Skip to content

Conversation

@h4nsu
Copy link
Contributor

@h4nsu h4nsu commented Jan 25, 2024

No description provided.

@h4nsu h4nsu requested review from UladAleph and deuszx January 25, 2024 15:41
@deuszx
Copy link
Contributor

deuszx commented Jan 26, 2024

In general I'm ready to approve the PR but I wonder whether you've considered the current situation with 5.0.0-rc release - the "rc" part means it's release candidate only, so there will come 5.0.0 release at some point. In theory, 5.0.0 release can be backwards incompatible with the *-rc release and here we're already releasing the new version.

What do you think?

@h4nsu
Copy link
Contributor Author

h4nsu commented Jan 26, 2024

Yes, I'm aware it's maybe a bit premature. But I tested these changes also on version use-ink/ink#2063 which most likely will end up as ink! 5.0.0. Also, this repo here has versioned releases to crates, I think nothing particularly bad will happen if the main branch contains some "work-in-progress" for some time.

@deuszx
Copy link
Contributor

deuszx commented Jan 26, 2024

So just by bumping the version in Cargo.toml here, it won't publish automatically to crates.io?

@h4nsu
Copy link
Contributor Author

h4nsu commented Jan 26, 2024

Nope, publishing on crates.io is a manual process triggered locally via cargo, not from GH

@deuszx
Copy link
Contributor

deuszx commented Jan 26, 2024

Nope, publishing on crates.io is a manual process triggered locally via cargo, not from GH

Personally I prefer when it's done automatically, when it detects a new version of Cargo.toml but that's for another discussion.

Copy link

@UladAleph UladAleph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool, I've been playing around with it and everything seems to work, nicely done!

@h4nsu h4nsu merged commit 85af736 into main Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants