-
Notifications
You must be signed in to change notification settings - Fork 67
A0-1235: ticket token #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
95d0bc4
init tikcet token
fbielejec a09d372
throw i fnot One
fbielejec d9d9f66
wip : reworking base lib
fbielejec 72d77b5
wip
fbielejec 1429c38
wip : altering deploy script
fbielejec 400a627
wip : deployment script
fbielejec 2dee371
fix
fbielejec 351674a
wip fixit
fbielejec bd05c68
fixed deployment script
fbielejec 46bc612
wip : test
fbielejec 78723ad
cleanup
fbielejec 89da634
clean
fbielejec dfcfe0e
ignore addresses file
fbielejec f7220d9
comment
fbielejec a66d7b1
simplified storage
fbielejec 5504983
clean
fbielejec 9b31d69
update err message
fbielejec 90abc65
Update contracts/button/Cargo.toml
fbielejec 4aa078d
BN
fbielejec efb5ec5
comments addressed
fbielejec 3343816
comments addressed
fbielejec 88f2130
newline char
fbielejec a395c6b
not needed
fbielejec 19c9765
updated README
fbielejec c3d76b8
fix typo
fbielejec d83561e
typo
fbielejec c4cd044
cleanup
fbielejec 054ce75
cleanup
fbielejec 17e81cc
remove comment
fbielejec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,3 +23,6 @@ p2p_secret | |
| # Python | ||
| __pycache__/ | ||
| *.py[cod] | ||
|
|
||
| # ink! | ||
| contracts/addresses.json | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
privilegeson line 90.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 43 as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I found just one typo, could you comment on the line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aleph-node/contracts/access_control/lib.rs
Line 43 in 2cecffa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And later uses. I do not see the second typo as well, so must have mixed up files. Will find it in a sec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It crops up a couple of times in 3 files
contracts/button/lib.rs(aleph-node/contracts/button/lib.rs
Line 42 in 2cecffa
contracts/access_control/lib.rs(these are the ones you have probably already fixed) andcontracts/scripts/deploy.sh(in comments).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, should be fixed now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deploy.shstill has a couple in comments, upper case. Other than that, fixed.