Skip to content

A0-1526: Sign addressing information #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timorl merged 4 commits into from
Dec 12, 2022
Merged

A0-1526: Sign addressing information #798

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85291cb
Sign addressing information
Dec 8, 2022
9dafc6e
Better name for verification
Dec 9, 2022
853cebf
Merge branch 'main' into A0-1526-krampus
Dec 9, 2022
6fe797d
Elaborate why zero signatures
Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Elaborate why zero signatures
  • Loading branch information
timorl committed Dec 12, 2022
commit 6fe797d1bd8150c4d71ef82f342d1492cd531923
3 changes: 3 additions & 0 deletions finality-aleph/src/tcp_network.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,9 @@ impl TryFrom<Vec<LegacyTcpMultiaddress>> for SignedTcpAddressingInformation {
fn try_from(legacy: Vec<LegacyTcpMultiaddress>) -> Result<Self, Self::Error> {
let addressing_information = legacy.try_into()?;
// This will never get validated, but that is alright and working as intended.
// We temporarily accept legacy messages and there is no way to verify them completely,
// since they were unsigned previously. In the next update we will remove this, and the
// problem will be completely gone.
let signature = [0; 64].into();
Ok(SignedTcpAddressingInformation {
addressing_information,
Expand Down