Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
2e22b79
dont use String for creating connections
krzysztofziobro Dec 27, 2022
20aafa6
do not wrap client
krzysztofziobro Dec 27, 2022
1f10b03
wip
krzysztofziobro Dec 28, 2022
2f5cda9
should work as old one
krzysztofziobro Dec 28, 2022
f5b769f
hide connection
krzysztofziobro Dec 28, 2022
44a4e9a
hide the rest
krzysztofziobro Dec 28, 2022
1472fd7
Don not hide clone
krzysztofziobro Dec 28, 2022
40225ca
Merge branch 'main' into A0-1613-improve-connection
krzysztofziobro Dec 29, 2022
168ce19
bump
krzysztofziobro Dec 29, 2022
0247e81
wip
krzysztofziobro Dec 30, 2022
4c1a6eb
wrap client
krzysztofziobro Dec 30, 2022
e41d124
rename client
krzysztofziobro Dec 30, 2022
7968aea
add Clone
krzysztofziobro Dec 30, 2022
9a979f6
Merge branch 'main' into A0-1613-improve-connection
krzysztofziobro Dec 30, 2022
50d7071
more general adder
krzysztofziobro Dec 30, 2022
dba9561
Add AsSigned
krzysztofziobro Dec 30, 2022
d700129
add impls for references
krzysztofziobro Dec 30, 2022
e45f361
wip
krzysztofziobro Jan 2, 2023
e6839b8
change TreasurySudoApi
krzysztofziobro Jan 2, 2023
8ec4625
Merge branch 'main' into A0-1613-improve-connection
krzysztofziobro Jan 2, 2023
3bf05d5
add methods to SignedConnectionApi
krzysztofziobro Jan 2, 2023
6b259b2
Merge branch 'A0-1613-improve-connection' of github.com:Cardinal-Cryp…
krzysztofziobro Jan 2, 2023
23d5a58
remove unnecessary casts
krzysztofziobro Jan 2, 2023
5600e11
Merge branch 'main' into A0-1613-improve-connection
krzysztofziobro Jan 2, 2023
b7ad771
review part 1
krzysztofziobro Jan 2, 2023
d156320
Merge branch 'A0-1613-improve-connection' of github.com:Cardinal-Cryp…
krzysztofziobro Jan 2, 2023
ef5625d
review part 2
krzysztofziobro Jan 2, 2023
af4d737
Make AsConnection visible only in crate
krzysztofziobro Jan 3, 2023
d15be1b
Merge branch 'main' into A0-1613-improve-connection
krzysztofziobro Jan 3, 2023
70db49a
Remove unnecessary dependencies on ConnectionApi
krzysztofziobro Jan 4, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change TreasurySudoApi
  • Loading branch information
krzysztofziobro committed Jan 2, 2023
commit e6839b8bda38e15ea18189cd7abf46cad12ea0ef
4 changes: 2 additions & 2 deletions aleph-client/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ pub type BlockHash = H256;
pub(crate) type SubxtClient = OnlineClient<AlephConfig>;

pub use connections::{
AsConnection, Connection, ConnectionApi, RootConnection, SignedConnection, SignedConnectionApi,
SudoCall,
AsConnection, AsSigned, Connection, ConnectionApi, RootConnection, SignedConnection,
SignedConnectionApi, SudoCall,
};

#[derive(Copy, Clone)]
Expand Down
4 changes: 2 additions & 2 deletions aleph-client/src/pallets/treasury.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use crate::{
pallets::{elections::ElectionsApi, staking::StakingApi},
AccountId, BlockHash,
Call::Treasury,
ConnectionApi, RootConnection, SignedConnection, SignedConnectionApi, SudoCall, TxStatus,
ConnectionApi, RootConnection, SignedConnectionApi, SudoCall, TxStatus,
};

#[async_trait::async_trait]
Expand Down Expand Up @@ -62,7 +62,7 @@ impl<C: ConnectionApi> TreasuryApi for C {
}

#[async_trait::async_trait]
impl TreasuryUserApi for SignedConnection {
impl<S: SignedConnectionApi> TreasuryUserApi for S {
async fn propose_spend(
&self,
amount: Balance,
Expand Down
6 changes: 2 additions & 4 deletions bin/cliain/src/keys.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use aleph_client::{
session::{SessionApi, SessionUserApi},
staking::StakingUserApi,
},
AccountId, AsSigned, Connection, RootConnection, SignedConnection, TxStatus,
AccountId, Connection, RootConnection, SignedConnection, TxStatus,
};
use hex::ToHex;
use log::{error, info};
Expand All @@ -26,9 +26,7 @@ pub async fn prepare_keys(
.await
.unwrap();
let new_keys = connection.author_rotate_keys().await?;
connection
.set_keys(new_keys, TxStatus::Finalized)
.await?;
connection.set_keys(new_keys, TxStatus::Finalized).await?;
Ok(())
}

Expand Down
4 changes: 1 addition & 3 deletions bin/cliain/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@ mod validators;
mod version_upgrade;
mod vesting;

use aleph_client::{
keypair_from_string, Connection, RootConnection, SignedConnection,
};
use aleph_client::{keypair_from_string, Connection, RootConnection, SignedConnection};
pub use commands::Command;
pub use contracts::{
call, instantiate, instantiate_with_code, owner_info, remove_code, upload_code,
Expand Down
4 changes: 2 additions & 2 deletions bin/cliain/src/treasury.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ pub async fn propose(connection: SignedConnection, amount_in_tokens: u64, benefi
/// Delegates to `aleph_client::approve_treasury_proposal`.
pub async fn approve(connection: RootConnection, proposal_id: u32) {
connection
.approve(proposal_id, TxStatus::Finalized)
.sudo_approve(proposal_id, TxStatus::Finalized)
.await
.unwrap();
}

/// Delegates to `aleph_client::reject_treasury_proposal`.
pub async fn reject(connection: RootConnection, proposal_id: u32) {
connection
.reject(proposal_id, TxStatus::Finalized)
.sudo_reject(proposal_id, TxStatus::Finalized)
.await
.unwrap();
}
4 changes: 2 additions & 2 deletions e2e-tests/src/test/treasury.rs
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ pub async fn treasury_access() -> anyhow::Result<()> {
}

async fn approve_treasury_proposal(connection: &RootConnection, id: u32) -> anyhow::Result<()> {
connection.sudo_approve(id, TxStatus::Finalized).await?;
connection.approve(id, TxStatus::Finalized).await?;
let approvals = connection.approvals(None).await;
assert!(approvals.contains(&id));

Expand All @@ -150,7 +150,7 @@ async fn reject_treasury_proposal(connection: &RootConnection, id: u32) -> anyho
)
.await;
});
connection.sudo_reject(id, TxStatus::Finalized).await?;
connection.reject(id, TxStatus::Finalized).await?;
handle.await?;

Ok(())
Expand Down