Skip to content

A0-1770: Add basic interfaces used and exposed by sync #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timorl merged 6 commits into from
Dec 30, 2022
Merged

A0-1770: Add basic interfaces used and exposed by sync #837

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
13b633b
Add basic interfaces used and exposed by sync
Dec 29, 2022
466a88e
Huh, hashes are `Copy`
Dec 29, 2022
d3e3203
Better verification abstraction
Dec 29, 2022
2745cab
Merge branch 'main' into A0-1770-hicky
Dec 29, 2022
ef73c02
Use BlockNumber
Dec 29, 2022
1b6cc16
Merge branch 'main' into A0-1770-hicky
Dec 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Huh, hashes are Copy
  • Loading branch information
timorl committed Dec 29, 2022
commit 466a88e4f4baa79599f4564eebcde9ddc5d3daab
2 changes: 1 addition & 1 deletion finality-aleph/src/sync/substrate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ impl<H: SubstrateHeader> Header for H {
fn parent_id(&self) -> Option<Self::Identifier> {
let number = self.number().checked_sub(&One::one())?;
Some(BlockId {
hash: self.parent_hash().clone(),
hash: *self.parent_hash(),
number,
})
}
Expand Down