ada-url: Substitute layer.json placeholders before treating as URLs #1084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @kring! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR into #1072.
It bothered me that the URL placeholders (like
{z}) in the tile URL templates in layer.json were escaped, and thensubstituteTemplateParametershad to deal with this potential escaping. So this is an attempt to avoid that in a fairly simple way: substitute the values into the template URL before treating it as a URL.I think this is fairly reasonable. A URL with placeholders is not a valid URL, so don't try to pretend it is. If this looks reasonable to you @azrogers, then I think the changes to
substituteTemplateParametersto allow escaped placeholders can be reverted.The other places we were using placeholders in URLs (
UrlTemplateRasterOverlayandWebMapTileServiceRasterOverlay) were already doing this, perhaps accidentally.