Skip to content

Abstrating Network provider logic #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FSM1 merged 59 commits into from
Jun 18, 2021
Merged

Abstrating Network provider logic #70

FSM1 merged 59 commits into from
Jun 18, 2021

Conversation

@RyRy79261
Copy link
Contributor

@RyRy79261 RyRy79261 commented Apr 28, 2021 •
edited by FSM1
Loading

closes #68
closes #71

@RyRy79261 RyRy79261 added the Type: Enhancement Added to issues and PRs when a change includes improvements or optimizations. label Apr 28, 2021
@RyRy79261 RyRy79261 self-assigned this Apr 28, 2021
@render
Copy link

render bot commented Apr 28, 2021

Your Render PR Server URL is https://chainbridge-pr-70.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c24p2ve1aaa1enh0ihng.

@lgtm-com
Copy link

lgtm-com bot commented Apr 28, 2021

This pull request introduces 1 alert when merging 2fd9d60 into 3bf1638 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 30, 2021

This pull request introduces 1 alert when merging 57a21f4 into 9e7652b - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 7, 2021

This pull request introduces 1 alert when merging d8220b1 into 9e7652b - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 7, 2021

This pull request introduces 1 alert when merging 5724715 into 9e7652b - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 10, 2021

This pull request introduces 3 alerts when merging b758c7e into 9e7652b - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

RyRy79261 and others added 13 commits May 24, 2021 21:21
@RyRy79261
Refactored home adapter to context (#73)
630b3b7 
* Refactored again

* Refactored modal

* Included

* Compiles

* Can connect again

* It connects now

* Trying to set destination

* Context for the destination chain

* Destination is provider

* Compiles

* Mostly works

* Refactored wrap & network unsuported modal

* Substrate provider init

* Added in

* Version issue

* Polkadot.js is a dumpster fire
@RyRy79261
Updating comments
f4289f3
@RyRy79261
Polkadot...
6e27838
@RyRy79261
Balance fetched
23c0b4a
@RyRy79261
Selecting token
7d9d9b1
@RyRy79261
Transfer sub to evm works
7c09fff
@RyRy79261
Added test listener logic
de45a50
@RyRy79261
Web3 issues
e3ebcdf
@RyRy79261
Revert
361d44e
@RyRy79261
Web3 eish
8cb033b
@FSM1
fix EVM home chain
6de6685
@FSM1
setup for GETH chainId 5
f5f211a
@RyRy79261
Present state
7f81f4b
ansermino
ansermino reviewed Jun 9, 2021
View reviewed changes
@lgtm-com
Copy link

lgtm-com bot commented Jun 9, 2021

This pull request introduces 6 alerts and fixes 1 when merging 56799f1 into c32e723 - view on LGTM.com

new alerts:

  • 6 for Unused variable, import, function or class

fixed alerts:

  • 1 for Useless comparison test

@ansermino @FSM1
Adapter modularity refactor (#77)
efad8dd 
* Refactors apis and cleanup a bit. Adds scripts for centrifuge

* Renames setup cmds

* more fixes

Co-authored-by: Michael Yankelev <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Jun 14, 2021

This pull request introduces 6 alerts and fixes 1 when merging efad8dd into c32e723 - view on LGTM.com

new alerts:

  • 6 for Unused variable, import, function or class

fixed alerts:

  • 1 for Useless comparison test

@lgtm-com
Copy link

lgtm-com bot commented Jun 15, 2021

This pull request introduces 6 alerts and fixes 1 when merging 21ad0f9 into c32e723 - view on LGTM.com

new alerts:

  • 6 for Unused variable, import, function or class

fixed alerts:

  • 1 for Useless comparison test

@lgtm-com
Copy link

lgtm-com bot commented Jun 15, 2021

This pull request introduces 5 alerts and fixes 1 when merging 225c887 into c32e723 - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class

fixed alerts:

  • 1 for Useless comparison test

@lgtm-com
Copy link

lgtm-com bot commented Jun 15, 2021

This pull request introduces 5 alerts and fixes 1 when merging 7e6cf09 into c32e723 - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class

fixed alerts:

  • 1 for Useless comparison test

@lgtm-com
Copy link

lgtm-com bot commented Jun 15, 2021

This pull request introduces 5 alerts and fixes 1 when merging b70cda0 into c32e723 - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class

fixed alerts:

  • 1 for Useless comparison test

@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2021

This pull request introduces 5 alerts and fixes 1 when merging 9136d65 into c32e723 - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class

fixed alerts:

  • 1 for Useless comparison test

@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2021

This pull request introduces 1 alert and fixes 1 when merging 32291fc into c32e723 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Useless comparison test

ansermino
ansermino reviewed Jun 16, 2021
View reviewed changes
@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2021

This pull request introduces 1 alert and fixes 1 when merging d47430e into c32e723 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Useless comparison test

@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2021

This pull request introduces 1 alert and fixes 1 when merging 951d7f5 into c32e723 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Useless comparison test

@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2021

This pull request introduces 1 alert and fixes 1 when merging c9a7423 into c32e723 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Useless comparison test

ansermino
ansermino reviewed Jun 17, 2021
View reviewed changes
@lgtm-com
Copy link

lgtm-com bot commented Jun 17, 2021

This pull request introduces 1 alert and fixes 1 when merging 48e5b87 into c32e723 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Useless comparison test

@FSM1 FSM1 merged commit 8789459 into main Jun 18, 2021
@FSM1 FSM1 deleted the feat/chain-adapters-68 branch June 18, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@FSM1 FSM1 FSM1 approved these changes

@ansermino ansermino ansermino left review comments

@mikiquantum mikiquantum mikiquantum left review comments

@roethke roethke roethke left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@RyRy79261 RyRy79261

Labels

Type: Enhancement Added to issues and PRs when a change includes improvements or optimizations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable Substrate support Chainbridge Context and EVM Homechain/DestinationChain Adapters

7 participants

@RyRy79261 @FSM1 @ansermino @mikiquantum @roethke @Tbaut