feat(feed): make submit extrinsic in feed-pallet operational #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clearloop
commented
May 28, 2021
mattsse
suggested changes
Jun 1, 2021
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
a few changes are required, but should make the whole thing more sound
mattsse
reviewed
Jun 1, 2021
mattsse
suggested changes
Jun 1, 2021
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
Now we need to use the post weight dispatch correction instead of requiring an additional parameter
mattsse
suggested changes
Jun 1, 2021
mattsse
suggested changes
Jun 2, 2021
mattsse
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Mark the weight of
submitasDispatchClass::OperationalIssues
Closes paritytech/substrate#22
Closes paritytech/substrate#23