Skip to content

Conversation

@wemeetagain
Copy link
Member

Builds off #87
Implements https://github.com/libp2p/specs/blob/master/pubsub/gossipsub/gossipsub-v1.1.md#flood-publishing

Add floodPublish option, defaulted to true
With flood publishing on:
Self-published messages should be sent to all peers with scores above the publish threshold

With flood publishing off:
Self-published messages should be sent using gossipsub 1.0 functionality

@wemeetagain wemeetagain requested a review from vasco-santos June 17, 2020 15:54
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020

Codecov Report

Merging #89 into gsv1.1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           gsv1.1      #89   +/-   ##
=======================================
  Coverage   80.00%   80.00%           
=======================================
  Files           1        1           
  Lines          10       10           
=======================================
  Hits            8        8           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee32618...0a49b20. Read the comment docs.

@wemeetagain wemeetagain changed the base branch from master to gsv1.1 June 17, 2020 16:29
@wemeetagain
Copy link
Member Author

I'm going to update getGossipPeers in a separate PR first for use here.
Looking at the go implementation, the gossipsub v1.0 behavior is also tweaked, uses the publish threshold to select mesh peers. This (and other) features will benefit getGossipPeers to be updated to suit

@wemeetagain wemeetagain force-pushed the cayman/gs1.1-flood-publish branch from b9e7f2b to 0a49b20 Compare June 17, 2020 17:37
Copy link
Collaborator

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! #90 should get in first

@wemeetagain wemeetagain merged commit a30801b into gsv1.1 Jun 18, 2020
@wemeetagain wemeetagain deleted the cayman/gs1.1-flood-publish branch June 18, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants