fix: avoid recomputing indexed attestations during block import #8637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Summary of ChangesHello @nflaig, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a significant performance optimization within the block processing pipeline by addressing the redundant calculation of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the performance issue of recomputing indexed attestations by introducing a deduplication mechanism. The changes are well-structured, computing the indexed attestations once during verifyBlocksInEpoch and then passing them down for use in signature verification and block import. The implementation is clean, and the necessary updates to data structures, function signatures, and tests are all correctly handled. This is a solid improvement that should reduce redundant computations as intended.
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
changed the title
nflaig
changed the title
twoeths
previously approved these changes
Nov 28, 2025
Contributor
twoeths
left a comment
twoeths
left a comment
There was a problem hiding this comment.
looks good to me
- on feat4 mainnet node
- same type of node on unstable
- same type of node on stable
nflaig
commented
Nov 28, 2025
Member
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an optimization to avoid recomputing indexed attestations during block import by pre-computing and caching them during block verification. The changes are well-implemented and correctly propagate the pre-computed indexedAttestations through the block processing pipeline, from verifyBlocksInEpoch to importBlock and verifyBlocksSignatures. My review includes a couple of suggestions to improve code clarity and maintainability.
wemeetagain
approved these changes
Dec 2, 2025
twoeths
approved these changes
Dec 3, 2025
Member
Author
|
I redeployed this yesterday to 
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #8637 +/- ##
=========================================
Coverage 52.02% 52.02%
=========================================
Files 848 848
Lines 65837 65815 -22
Branches 4811 4810 -1
=========================================
- Hits 34250 34242 -8
+ Misses 31518 31504 -14
Partials 69 69 🚀 New features to boost your workflow:
|
Member
|
🎉 This PR is included in v1.38.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Store indexed attestations for each block during block/signature verification to avoid recomputing them during import
indexedAttestationsByBlockonce during verificationFullyVerifiedBlockto include indexed attestations for block importCloses #8625