Skip to content

feat: use different snappy implementations for different topics #8670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
twoeths wants to merge 9 commits into from
Closed

feat: use different snappy implementations for different topics #8670

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4419e35
feat: add snappyjs implementation in ts
twoeths Dec 5, 2025
cbe7cfa
feat: implement ISnappyDecompressor interface
twoeths Dec 5, 2025
e717d37
feat: use different uncompressor based on topic type
twoeths Dec 5, 2025
3f091e8
fix: remove snappy-js
twoeths Dec 5, 2025
c94ede7
fix: make consistent behaviour across implementations
twoeths Dec 5, 2025
2d4de6a
fix: use snappy-wasm for beacon_block and data_column_sidecar only
twoeths Dec 5, 2025
a74d316
fix: use Buffer.alloc()
twoeths Dec 5, 2025
95416e8
fix: update snappy benchmark using ISnappyDecompressor interface
twoeths Dec 5, 2025
732860c
chore: link to snappy-js upstream repo
twoeths Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: use snappy-wasm for beacon_block and data_column_sidecar only
  • Loading branch information
@twoeths
twoeths committed Dec 5, 2025
commit 2d4de6aed95f14bf24f263593dca86901471ecf0
8 changes: 5 additions & 3 deletions packages/beacon-node/src/network/gossip/snappy/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,11 @@ import {SnappyWasmDecompressor} from "./snappy-wasm.js";
*/
export function getSnappyDecompressor(topicType: GossipType, data: Uint8Array): ISnappyDecompressor {
switch (topicType) {
case GossipType.beacon_attestation:
return new SnappyDecompressor(data);
default:
case GossipType.beacon_block:
case GossipType.blob_sidecar:
case GossipType.data_column_sidecar:
return new SnappyWasmDecompressor(data);
default:
return new SnappyDecompressor(data);
}
}
Loading