Skip to content

Conversation

@jtraglia
Copy link
Contributor

Motivation

This PR is follow up from:

Description

This PR enables a few optional features:

  • auto_add_missing_entries: Add missing spec items to the relevant mapping files. It will not add missing spec items if there's an exception for that spec item.
  • auto_standardize_names: Automatically add #fork tags to specref names, for explicitness.
  • require_exceptions_have_fork: Require exceptions include a #fork tag.

It also removes the KZG functions (which clients do not implement) from the functions.yml file. @ensi321 could you give me a list of other items we want to remove?

And it also fixes the search query for get_committee_assignment which was moved before the first PR was merged.

AI Assistance Disclosure

I used AI to remove the KZG functions.

@jtraglia jtraglia requested a review from a team as a code owner January 26, 2026 16:33
@jtraglia jtraglia changed the title Enable specref features & remove unnecessary spec items feat: enable specref features & remove unnecessary spec items Jan 26, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jtraglia, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the management of specification references by activating new automation features within the '.ethspecify.yml' configuration. It also systematically updates various YAML files to include explicit fork tags in spec item names, thereby enhancing the clarity and maintainability of the project's specification definitions.

Highlights

  • Specref Configuration Enhancement: Enabled 'auto_add_missing_entries', 'auto_standardize_names', and 'require_exceptions_have_fork' features in the '.ethspecify.yml' configuration to automate and enforce naming conventions.
  • Standardization of Spec Item Names: Applied '#fork' tags to numerous spec item names across 'configs.yml', 'constants.yml', 'containers.yml', 'dataclasses.yml', 'presets.yml', and 'types.yml' for improved explicitness and consistency in referencing different Ethereum forks.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully enables several optional specrefs features, including auto_add_missing_entries, auto_standardize_names, and require_exceptions_have_fork. The changes across various YAML files (configs.yml, constants.yml, containers.yml, dataclasses.yml, presets.yml, types.yml) consistently apply the #<fork_name> tag to the name fields, which aligns with the auto_standardize_names feature. The modifications are straightforward configuration updates and appear correct and well-aligned with the PR's stated motivation. No critical, high, or medium severity issues were found in the provided patches.

@ensi321
Copy link
Contributor

ensi321 commented Jan 26, 2026

could you give me a list of other items we want to remove?

@jtraglia I think the current list looks good. We can also remove compute_merkle_proof since its definition is empty.

Also I would prefer to set auto_add_missing_entries to false. This way it reduces noises in files.

@ensi321 ensi321 merged commit 375b1b3 into ChainSafe:unstable Jan 27, 2026
17 of 19 checks passed
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.16%. Comparing base (a210743) to head (e73b6f4).
⚠️ Report is 1 commits behind head on unstable.

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #8788   +/-   ##
=========================================
  Coverage     52.16%   52.16%           
=========================================
  Files           848      848           
  Lines         64059    64059           
  Branches       4721     4721           
=========================================
  Hits          33419    33419           
  Misses        30571    30571           
  Partials         69       69           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants