-
-
Notifications
You must be signed in to change notification settings - Fork 434
feat: enable specref features & remove unnecessary spec items #8788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @jtraglia, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the management of specification references by activating new automation features within the '.ethspecify.yml' configuration. It also systematically updates various YAML files to include explicit fork tags in spec item names, thereby enhancing the clarity and maintainability of the project's specification definitions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully enables several optional specrefs features, including auto_add_missing_entries, auto_standardize_names, and require_exceptions_have_fork. The changes across various YAML files (configs.yml, constants.yml, containers.yml, dataclasses.yml, presets.yml, types.yml) consistently apply the #<fork_name> tag to the name fields, which aligns with the auto_standardize_names feature. The modifications are straightforward configuration updates and appear correct and well-aligned with the PR's stated motivation. No critical, high, or medium severity issues were found in the provided patches.
@jtraglia I think the current list looks good. We can also remove
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #8788 +/- ##
=========================================
Coverage 52.16% 52.16%
=========================================
Files 848 848
Lines 64059 64059
Branches 4721 4721
=========================================
Hits 33419 33419
Misses 30571 30571
Partials 69 69 🚀 New features to boost your workflow:
|
Motivation
This PR is follow up from:
Description
This PR enables a few optional features:
auto_add_missing_entries: Add missing spec items to the relevant mapping files. It will not add missing spec items if there's an exception for that spec item.auto_standardize_names: Automatically add#forktags to specref names, for explicitness.require_exceptions_have_fork: Require exceptions include a#forktag.It also removes the KZG functions (which clients do not implement) from the
functions.ymlfile. @ensi321 could you give me a list of other items we want to remove?And it also fixes the search query for
get_committee_assignmentwhich was moved before the first PR was merged.AI Assistance Disclosure
I used AI to remove the KZG functions.