Closes #1419 Registered unregistered models #1454
Conversation
project/accounts/admin.py
Outdated
| from threads.models import ( | ||
| Activity, | ||
| Civi, | ||
| CiviImage, | ||
| Fact, | ||
| Rationale, | ||
| Rebuttal, | ||
| Response, | ||
| Thread, | ||
| ) |
There was a problem hiding this comment.
Register threads models from within the threads app in the file threads/admin.py.
There was a problem hiding this comment.
Well noted @brylie. Should I go ahead to also register the Category and Notification model from their respective admin?
There was a problem hiding this comment.
Each model is registered in its respective admin.py, found within the same application directory.
There was a problem hiding this comment.
Oh @brylie I don't think that was the case, only the account module had an admin file that's why I initially registered all models there. However, I have created an admin file for thread, categories and notification modules, can I go ahead to push for a Pull Request?
There was a problem hiding this comment.
You can commit those changes in your register-models branch related to this pull request.
There was a problem hiding this comment.
Hello @brylie please I have successfully committed my changes.
|
Code Climate has analyzed commit dd6a705 and detected 0 issues on this pull request. View more on Code Climate. |
|
When creating a pull request that will resolve an issue, please link the pull request to the related issue(s) by using one of the supported keywords followed by the issue number in the pull request description. For example: Further details
|
TimOsahenru
changed the title
TimOsahenru
changed the title
TimOsahenru
changed the title
|
Hello @brylie thank you for the resources I hope I did it right, I have modified my PR |
|
@all-contributors please add @TimOsahenru for code |
|
I've put up a pull request to add @TimOsahenru! 🎉 |
2 participants
Closes #1419
Registered all unregistered models in the admin.py file located inside the account module