Add Following tab to the user profile view #1463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brylie
suggested changes
Nov 6, 2022
Contributor
Author
|
Implemented the suggested changes in 2 commits. @brylie Could you please have a look? |
brylie
reviewed
Nov 8, 2022
brylie
suggested changes
Nov 8, 2022
Contributor
Author
|
@brylie I renamed the view accordingly to the comments above. |
brylie
suggested changes
Nov 9, 2022
Contributor
brylie
left a comment
brylie
left a comment
There was a problem hiding this comment.
Overall, this PR looks good. There is just a bit more ambiguity in how we use "following" and "followers" here that we need to iron out.
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 7396104 and detected 0 issues on this pull request. View more on Code Climate. |
Contributor
Author
|
I believe everything is ironed out now. @brylie asking again for review. |
brylie
approved these changes
Nov 11, 2022
Contributor
|
@all-contributors please add @wippo-devops for code |
Contributor
|
I've put up a pull request to add @wippo-devops! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1447
All of these tasks should be done in the accounts app.
Description
Created a new view that shows followers of user (/profile//following). View shows clicable image icons of profile pictures of followers. If there are zero followers it shows message that no one is following.
I was thinking it might be good idea to add this to profile below the "About me" section, but it was not mentioned in the issue.