Port templates in core to Django templating syntax #1494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
project/core/templates/partials/notifications/notification_base.html
Outdated
Show resolved
Hide resolved
project/core/templates/partials/notifications/notification_base.html
Outdated
Show resolved
Hide resolved
brylie
suggested changes
Feb 1, 2023
Contributor
brylie
left a comment
brylie
left a comment
There was a problem hiding this comment.
Make sure there is only one {% block content %} in each template HTML file.
Any Backbone.js template needs to be converted to Django template syntax.
5 tasks
brylie
reviewed
Feb 8, 2023
brylie
reviewed
Feb 8, 2023
brylie
reviewed
Feb 8, 2023
brylie
reviewed
Feb 8, 2023
brylie
reviewed
Feb 8, 2023
brylie
reviewed
Feb 8, 2023
brylie
reviewed
Feb 8, 2023
brylie
reviewed
Feb 8, 2023
project/core/templates/partials/notifications/notification_base.html
Outdated
Show resolved
Hide resolved
brylie
reviewed
Feb 8, 2023
project/core/templates/partials/notifications/notification_base.html
Outdated
Show resolved
Hide resolved
brylie
reviewed
Feb 8, 2023
project/core/templates/partials/notifications/notification_item.html
Outdated
Show resolved
Hide resolved
brylie
reviewed
Feb 8, 2023
project/core/templates/partials/notifications/notification_item.html
Outdated
Show resolved
Hide resolved
brylie
suggested changes
Feb 8, 2023
Contributor
brylie
left a comment
brylie
left a comment
There was a problem hiding this comment.
If a template doesn't extend base.htm, we don't need to add the block content. Please remove block content and endblock content from all files that don't extend base.html.
brylie
reviewed
Feb 8, 2023
brylie
reviewed
Feb 8, 2023
project/core/templates/partials/notifications/notification_base.html
Outdated
Show resolved
Hide resolved
brylie
reviewed
Feb 8, 2023
project/core/templates/partials/notifications/notification_item.html
Outdated
Show resolved
Hide resolved
brylie
reviewed
Feb 8, 2023
brylie
reviewed
Feb 8, 2023
brylie
reviewed
Feb 8, 2023
brylie
reviewed
Feb 8, 2023
project/core/templates/partials/notifications/notification_base.html
Outdated
Show resolved
Hide resolved
project/core/templates/partials/notifications/notification_item.html
Outdated
Show resolved
Hide resolved
brylie
suggested changes
Feb 10, 2023
brylie
suggested changes
Feb 11, 2023
project/core/templates/about.html
Outdated
| {% extends "base.html" %} | ||
| {% load static %} | ||
| {% load i18n %} | ||
| {% block content %} |
Contributor
There was a problem hiding this comment.
Move this block definition to line 12, after the page_title block
brylie
reviewed
Feb 11, 2023
project/core/templates/about.html
Outdated
| {% block page_title %}{% trans "About Us" %}{% endblock page_title %} | ||
|
|
||
| {% block backbone_template %} | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| {% block content %} |
|
Code Climate has analyzed commit fb7e2d1 and detected 0 issues on this pull request. View more on Code Climate. |
brylie
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1405
Description
Implemented Django templating syntax for all the templates in the core app