Skip to content

Added a factory file for the Category Model #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brylie merged 8 commits into from
Feb 19, 2023
Merged

Added a factory file for the Category Model #1496

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0f02e6f
Added a factory file for the Category Model
Nehemiah60 Feb 6, 2023
017a49c
Added factory file to apps
Nehemiah60 Feb 9, 2023
b1d54c0
Added factory file to apps
Nehemiah60 Feb 9, 2023
40a43d1
Added factory file to apps
Nehemiah60 Feb 9, 2023
6630449
Added factory file to apps
Nehemiah60 Feb 9, 2023
a2b5eeb
Added factory file to apps
Nehemiah60 Feb 9, 2023
762f44a
Added factory file to apps
Nehemiah60 Feb 9, 2023
1345209
Factory modelling for all the apps
Nehemiah60 Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion project/accounts/factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class Meta:
first_name = factory.Faker("lorem")
last_name = factory.Faker("lorem")
about_me = factory.Faker("lorem")
is_verified = factory.fuzzy.FuzzyChoice(choices=[False, False, False, False])
is_verified = factory.fuzzy.FuzzyChoice(choices=[False, False])
Copy link
Contributor

@brylie brylie Feb 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also allow True?

Suggested change
is_verified = factory.fuzzy.FuzzyChoice(choices=[False, False])
is_verified = factory.fuzzy.FuzzyChoice(choices=[True, False])

Copy link
Contributor Author

@Nehemiah60 Nehemiah60 Feb 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not so sure. Because the field had False as a default value. But I will make the changes @brylie

profile_image = factory.Faker("image_url")
profile_image_thumb = factory.Faker("image_url")

Expand Down
4 changes: 0 additions & 4 deletions project/threads/factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,13 @@ def facts(self, create, extracted, **kwargs):
for fact in extracted:
self.facts.add(fact)

@factory.post_generation
def tags(self, create, extracted, **kwargs):
if not create:
return
if extracted:
for tag in extracted:
self.tags.add(tag)

@factory.post_generation
def objects(self, create, extracted, **kwargs):
if not create:
return
Expand Down Expand Up @@ -75,15 +73,13 @@ def linked_civis(self, create, extracted, **kwargs):
for linked_civi in extracted:
self.linked_civis.add(linked_civi)

@factory.post_generation
def tags(self, create, extracted, **kwargs):
if not create:
return
if extracted:
for tag in extracted:
self.tags.add(tag)

@factory.post_generation
def objects(self, create, extracted, **kwargs):
if not create:
return
Expand Down