Skip to content

Added a factory file for the Category Model #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brylie merged 8 commits into from
Feb 19, 2023
Merged

Added a factory file for the Category Model #1496

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0f02e6f
Added a factory file for the Category Model
Nehemiah60 Feb 6, 2023
017a49c
Added factory file to apps
Nehemiah60 Feb 9, 2023
b1d54c0
Added factory file to apps
Nehemiah60 Feb 9, 2023
40a43d1
Added factory file to apps
Nehemiah60 Feb 9, 2023
6630449
Added factory file to apps
Nehemiah60 Feb 9, 2023
a2b5eeb
Added factory file to apps
Nehemiah60 Feb 9, 2023
762f44a
Added factory file to apps
Nehemiah60 Feb 9, 2023
1345209
Factory modelling for all the apps
Nehemiah60 Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 54 additions & 5 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions project/categories/factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import factory

from .models import Category


class CategoryFactory(factory.django.DjangoModelFactory):
class Meta:
model = Category

name = factory.Faker("name")
Copy link
Contributor

@brylie brylie Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ´name´factory is used to generate names or people. Let's use Faker factory ´lorem´ here, since it is more like a keyword.

https://faker.readthedocs.io/en/master/providers/faker.providers.lorem.html

Copy link
Contributor

@brylie brylie Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = factory.Faker("name")
name = factory.Faker("lorem")



categories = CategoryFactory.create_batch(10)
for category in categories:
print(category.name)
Copy link
Contributor

@brylie brylie Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to add these lines, since we will want to generate the fake content via a manual command.

Suggested change
categories = CategoryFactory.create_batch(10)
for category in categories:
print(category.name)

Copy link
Contributor Author

@Nehemiah60 Nehemiah60 Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @brylie. I will work on it. If you get time, please you can also review the other PR, I mentioned. Thanks.

1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ ipython = "^8.5.0"
django-debug-toolbar = "^3.7.0"
django-linear-migrations = "^2.5.1"
pre-commit = "^2.20.0"
factory-boy = "^3.2.1"

[tool.isort]
profile = "black"
Expand Down