loaded static template tag in global_nav.html #1502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brylie
reviewed
Apr 22, 2023
| @@ -1,4 +1,5 @@ | |||
|
|
|||
| {% load static %} | |||
| {% load notifications_tags %} | |||
Contributor
There was a problem hiding this comment.
Do we need to load notification_tags here or is “load static” all that is needed?
Contributor
Author
There was a problem hiding this comment.
Hi Brylie, thanks for responding.
Sorry I probably should have mentioned this in my pull request, when I don't load in notifications_tags then I get a template syntax error for live_notify_badge tag.
brylie
approved these changes
Apr 24, 2023
Contributor
|
@all-contributors please add @ashfaq1934 for code |
Contributor
|
I've put up a pull request to add @ashfaq1934! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1501
Description
This pull request resolves the template syntax error that occurs in global_nav.html.