Fix username and e-mail visual bug in user setup #235
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CiviWiki Privacy Policy
…oyment_instructions Heroku Deployment Instructions
…pendency_upgrade Reapply python dependency upgrades
…ckend_changes Backend API changes for the restructured frontend
Thread edit refresh
Add Changes needed to close PR CiviWiki#202
brylie
approved these changes
Dec 7, 2018
|
Looks good. Is this PR ready for review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #231
I fixed the visual bug by updating text fields through Materialize before advancing from the first step. I wasn't sure where the fields were being populated in the first place, so I didn't know of a better place to do this (after setting the fields would have made the most sense)
Some formatting changes to follow the django style guide, but just in the proximity of the line I added.