Skip to content

Treat uppercase Q as quit shortcut#2074

Merged
ClementTsang merged 1 commit into
ClementTsang:mainfrom
puneetdixit200:fix/572-caps-lock-shortcuts
May 24, 2026
Merged

Treat uppercase Q as quit shortcut#2074
ClementTsang merged 1 commit into
ClementTsang:mainfrom
puneetdixit200:fix/572-caps-lock-shortcuts

Conversation

@puneetdixit200
Copy link
Copy Markdown
Contributor

@puneetdixit200 puneetdixit200 commented May 22, 2026

Description

Makes the quit shortcut accept uppercase Q as well as lowercase q when no modifiers are present and the user is not in a search field. This helps terminals that report Caps Lock as an uppercase character while leaving the existing uppercase-only shortcuts unchanged.

Issue

Related: #572

Testing

Not rerun for this description-only cleanup. The code diff remains the same one-line shortcut match change.

Platforms tested:

  • Windows
  • macOS (15.7.5)
  • Linux
  • Other

Checklist

  • If this PR adds or changes a dependency, please justify this in the description
  • If this is a code change, areas your change affects have been linted using (cargo fmt)
  • If this is a code change, your changes pass cargo clippy --all -- -D warnings
  • If this is a code change, new tests were added if relevant
  • If this is a code change, your changes pass cargo test
  • The change has been tested to work (see above) and doesn't appear to break other things
  • Documentation has been updated if needed (README.md, help menu, docs, configs, etc.)
  • There are no merge conflicts
  • You have reviewed your changes first
  • The pull request passes the provided CI pipeline

Other

AI assistance was used for this small change, and the final code was reviewed before submission.

@ClementTsang
Copy link
Copy Markdown
Owner

This does not close that issue.

@ClementTsang
Copy link
Copy Markdown
Owner

ClementTsang commented May 23, 2026

Also not exactly sure why you need that test there tbh... that's like, AI slop testing.

Copy link
Copy Markdown
Owner

@ClementTsang ClementTsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the slop test.

@puneetdixit200 puneetdixit200 force-pushed the fix/572-caps-lock-shortcuts branch from 3349023 to 2f3f92a Compare May 23, 2026 10:21
@ClementTsang
Copy link
Copy Markdown
Owner

Thanks. Will merge once CI finishes.

@ClementTsang
Copy link
Copy Markdown
Owner

@all-contributors please add @puneetdixit200 for code.

@allcontributors
Copy link
Copy Markdown
Contributor

@ClementTsang

I've put up a pull request to add @puneetdixit200! 🎉

@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 62.48%. Comparing base (cd22500) to head (2f3f92a).

Files with missing lines Patch % Lines
src/event.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2074      +/-   ##
==========================================
- Coverage   62.76%   62.48%   -0.29%     
==========================================
  Files         130      130              
  Lines       18756    18756              
==========================================
- Hits        11773    11720      -53     
- Misses       6983     7036      +53     
Flag Coverage Δ
macos-14 50.35% <0.00%> (-0.02%) ⬇️
ubuntu-24.04 61.46% <0.00%> (-0.29%) ⬇️
windows-2022 50.09% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ClementTsang ClementTsang merged commit 799bf21 into ClementTsang:main May 24, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants