Treat uppercase Q as quit shortcut#2074
Merged
ClementTsang merged 1 commit intoMay 24, 2026
Merged
Conversation
Owner
|
This does not close that issue. |
Owner
|
Also not exactly sure why you need that test there tbh... that's like, AI slop testing. |
ClementTsang
requested changes
May 23, 2026
Owner
ClementTsang
left a comment
There was a problem hiding this comment.
Please remove the slop test.
3349023 to
2f3f92a
Compare
ClementTsang
approved these changes
May 23, 2026
Owner
|
Thanks. Will merge once CI finishes. |
Owner
|
@all-contributors please add @puneetdixit200 for code. |
Contributor
|
I've put up a pull request to add @puneetdixit200! 🎉 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2074 +/- ##
==========================================
- Coverage 62.76% 62.48% -0.29%
==========================================
Files 130 130
Lines 18756 18756
==========================================
- Hits 11773 11720 -53
- Misses 6983 7036 +53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes the quit shortcut accept uppercase
Qas well as lowercaseqwhen no modifiers are present and the user is not in a search field. This helps terminals that report Caps Lock as an uppercase character while leaving the existing uppercase-only shortcuts unchanged.Issue
Related: #572
Testing
Not rerun for this description-only cleanup. The code diff remains the same one-line shortcut match change.
Platforms tested:
Checklist
cargo fmt)cargo clippy --all -- -D warningscargo testREADME.md, help menu, docs, configs, etc.)Other
AI assistance was used for this small change, and the final code was reviewed before submission.