Skip to content

Conversation

@Enmk
Copy link
Contributor

@Enmk Enmk commented Jun 18, 2025

Mostly focused on fixing CI/CD on Linux

Closes #415 (supersedes)

Enmk added 7 commits June 9, 2025 19:17
ubuntu-22.04 and 24.04
- Using Ubuntu 22.04 and Ubuntu 24.04
- corresponding supported compilers
- Properly installing docker
- CompareRecursive fix for GCC-12 (fixes ClickHouse#425)
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates CI/CD workflows to support newer Ubuntu versions and compilers, improves Docker installation steps, and enhances the CompareRecursive utility with additional tests and type handling.

  • Expanded CompareRecursive tests to cover characters, string types, and containers of strings
  • Refactored utils_comparison.h to introduce L/R type aliases and handle char* via std::string_view
  • Updated GitHub Actions across Windows, macOS, and Linux: added wildcard branch triggers, new compiler matrix entries, and Docker verification

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ut/utils_ut.cpp Added new tests for CompareRecursive to cover char, string, and container cases
ut/utils_meta.h Minor formatting cleanup (added blank line)
ut/utils_comparison.h Introduced using L/R aliases and new char* overloads
.github/workflows/windows_msvc.yml Changed push trigger to all branches
.github/workflows/windows_mingw.yml Changed push trigger to all branches
.github/workflows/macos.yml Changed push trigger to all branches
.github/workflows/linux.yml Changed push trigger to all branches; revamped compiler matrix and Docker steps
Comments suppressed due to low confidence (6)

.github/workflows/windows_msvc.yml:7

  • [nitpick] The push trigger is now on all branches, but pull_request remains limited to master; consider aligning pull_request to '*' so feature-branch PRs also run CI.
    branches: [ '*' ]

.github/workflows/windows_mingw.yml:7

  • [nitpick] The push trigger is now on all branches, but pull_request remains limited to master; consider aligning pull_request to '*' so feature-branch PRs also run CI.
    branches: [ '*' ]

.github/workflows/macos.yml:7

  • [nitpick] The push trigger is now on all branches, but pull_request remains limited to master; consider aligning pull_request to '*' so feature-branch PRs also run CI.
    branches: [ '*' ]

.github/workflows/linux.yml:7

  • [nitpick] The push trigger is now on all branches, but pull_request remains limited to master; consider aligning pull_request to '*' so feature-branch PRs also run CI.
    branches: [ '*' ]

.github/workflows/linux.yml:25

  • The top-level matrix no longer defines an os axis, which may lead to runs with an undefined OS; reintroduce os: [ubuntu-22.04, ubuntu-24.04] or ensure every matrix entry specifies os.
        compiler: [clang-11, clang-14, clang-18, gcc-9, gcc-12, gcc-14]

ut/utils_ut.cpp:91

  • Lines 91–92 duplicate the same assertions from lines 89–90; consider removing these redundant tests to keep the suite concise.
    EXPECT_TRUE(CompareRecursive(vector_of_strings, vector_of_string_views));

@mshustov mshustov merged commit 85437b5 into ClickHouse:master Jun 18, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit tests build fails with GCC 12+

2 participants