Skip to content

Allow either *char or Query as BeginInsert arg #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theory wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow either *char or Query as BeginInsert arg #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Allow either *char or Query as BeginInsert arg 
To allow the user to configure other bits of the query, like settings.
  • Loading branch information
@theory
theory committed Dec 3, 2025
commit 2332c3f9eb7584d7f69dae632f78a027422dad4c
4 changes: 2 additions & 2 deletions clickhouse/client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1218,8 +1218,8 @@ void Client::Insert(const std::string& table_name, const std::string& query_id,
impl_->Insert(table_name, query_id, block);
}

Block Client::BeginInsert(const std::string& query) {
return impl_->BeginInsert(Query(query));
Block Client::BeginInsert(const Query& query) {
return impl_->BeginInsert(query);
}

Block Client::BeginInsert(const std::string& query, const std::string& query_id) {
Expand Down
2 changes: 1 addition & 1 deletion clickhouse/client.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ class Client {
void Insert(const std::string& table_name, const std::string& query_id, const Block& block);

/// Start an \p INSERT statement, insert batches of data, then finish the insert.
Block BeginInsert(const std::string& query);
Block BeginInsert(const Query& query);
Block BeginInsert(const std::string& query, const std::string& query_id);

/// Insert data using a \p block returned by \p BeginInsert.
Expand Down
Loading