-
Notifications
You must be signed in to change notification settings - Fork 614
[JDBC-V2] Fix Parser Issues #2579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
d1703cc
fixes CTE parsing issue and using table as alias
chernser 1f30b73
Merge branch 'main' into jdbc_fix_cte_parse
chernser e9fe471
Merge branch 'main' into jdbc_fix_cte_parse
chernser 9f4aa7a
Added more tests
chernser 2113b87
filled test statements
chernser 3a96804
moved parser to separate package to track coverage
chernser 25cca50
fixed show statement tests
chernser 6f7e415
Fixed statements with result set and several other
chernser b2d2399
fixed GRANT stmts and added REVOKE statements
chernser dfc938c
fixed more statement tests
chernser aefc7c9
added MOVE and UNDROP statements
chernser 4efa2c1
Fixed quota statements
chernser 25549e7
Fixed insert statements
chernser f9dd217
Fixed CTE and some minor bugs
chernser 8db01eb
fixed CTE arguments positioning and fixed add column expression
chernser 07eac76
fixed more statements
chernser 0f04adf
fixed column position in alter statement and renamed QUERY to JDBC_PA…
chernser 3e18522
created a SQL parser facade to implement SQL parser selection
chernser 9cb7738
implemented antlr4 two variants
chernser 0cbf958
Fixed issue with # comments
chernser 505272d
Added javaCC parser implementation. not a default. some tests failing
chernser fdfc35b
Fixed javacc to support single line comments and some new statements
chernser f02382f
Fixed some keyword issues
chernser 6372e4e
Fixed some more antlr4 issues
chernser cf863d4
Merge branch 'main' into jdbc_fix_cte_parse
chernser 4f45dc8
Added a few SQL tests fro Statement/PreparedStatement. Addded more te…
chernser b930ca2
Fixed javaCC for set roles statements and getting correct table name
chernser 24c8e81
Added new statements to javacc. fixed some existing statements
chernser 5f172d2
fixed alter table - type is not required.
chernser 967e7dc
added tests with lambda
chernser 8b2406e
fixed ANTLR4 for expressions with IP keyword
chernser 2b108b0
fixed in statement with multiple arguments
chernser b773b7e
fixed problem with detecting function in insert statement
chernser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixed javaCC for set roles statements and getting correct table name
- Loading branch information
commit b930ca2b63c526bd5fc488684d48cc133fdc87f8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting to ANTLR4 means that we are using ANTLR4 as the default one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for catching it!
Yes, we need to use JAVACC by default.