Skip to content

Conversation

@YBronst
Copy link
Contributor

@YBronst YBronst commented Sep 23, 2025

Added makeiso7z and makeutils7z; Cosmetic changes to buildme and xbuildme;
Added critical patches to tools_def.template, AcpiParser.c, and AcpiParser.h
And main.yml has been changed (it no longer produces warnings and errors).
Everything works fine and looks visually better.

@chris1111
Copy link
Contributor

GitHub CI already has python build-in
From what I've seen from recent commits, the build is broken on a commit that's very easy to fix.

@YBronst
Copy link
Contributor Author

YBronst commented Sep 24, 2025

I don't know where to enter the latest changes and how to filter the request correctly.
My last commit is going through without any warnings.
All previous errors were related to debugging main.yml
GitHub CI already has python build-in (But I put it in just in case. It doesn't interfere with anything).
You can remove this entire:

 - name: Check Xcode version

    run: |
      XCODE_VER=$(xcodebuild -version | grep Xcode | awk '{print $2}' | tr -d '[:space:]')
      echo "Detected Xcode version: $XCODE_VER"
      if [[ -z "$XCODE_VER" ]]; then
        echo "❌ Failed to detect Xcode version!"
        exit 1
      fi

      MAJOR_VER=${XCODE_VER%%.*}
      if [[ "$MAJOR_VER" -eq 26 ]]; then
        CHECK_VER=16
      else
        CHECK_VER=$MAJOR_VER
      fi

      if [[ "$CHECK_VER" -lt 16 ]]; then
        echo "❌ Xcode 16+ required!"
        exit 1
      fi

      echo "✅ Using Xcode version $XCODE_VER (check $CHECK_VER)"

  - name: Setup Python 3.13
    uses: actions/setup-python@v5
    with:
      python-version: '3.13'

  - name: Verify Python framework symlink
    run: |
      FRAMEWORK_PATH="/Library/Frameworks/Python.framework/Versions/3.13/bin/python3.13"
      if [ ! -x "$FRAMEWORK_PATH" ]; then
        echo "❌ Expected Python 3.13 at $FRAMEWORK_PATH not found!"
        exit 1
      fi
      echo "✅ Python 3.13 found at $FRAMEWORK_PATH"

  - name: Prepare Python env
    run: |
      python3.13 --version
      pip3 install --upgrade pip
      pip3 install setuptools
      pip3 install --upgrade setuptools

  - name: Download CloverGnuBuildTools
    run: |
      mkdir -p toolchain/tools/download
      cd toolchain/tools/download
      curl -L -o CloverBuildTools.zip https://github.com/YBronst/CloverBuildUtilities/releases/download/V.1.0/CloverBuildTools.zip
      unzip CloverBuildTools.zip
      cp -r CloverBuildTools/* .
      rm -rf CloverBuildTools CloverBuildTools.zip

actions runs: CI #16
Artifact download URL: Artifact Clover-GCC-15.1.0-756b02c5.zip

@chris1111
Copy link
Contributor

Sorry but you don't understand, you don't have to touch main.yml, this file as no problem for many years

@chris1111 chris1111 closed this Sep 25, 2025
@chris1111 chris1111 reopened this Sep 25, 2025
@chris1111 chris1111 closed this Sep 25, 2025
@chris1111
Copy link
Contributor

I don't know where to enter the latest changes and how to filter the request correctly. My last commit is going through without any warnings. All previous errors were related to debugging main.yml GitHub CI already has python build-in (But I put it in just in case. It doesn't interfere with anything). You can remove this entire:

 - name: Check Xcode version

    run: |
      XCODE_VER=$(xcodebuild -version | grep Xcode | awk '{print $2}' | tr -d '[:space:]')
      echo "Detected Xcode version: $XCODE_VER"
      if [[ -z "$XCODE_VER" ]]; then
        echo "❌ Failed to detect Xcode version!"
        exit 1
      fi

      MAJOR_VER=${XCODE_VER%%.*}
      if [[ "$MAJOR_VER" -eq 26 ]]; then
        CHECK_VER=16
      else
        CHECK_VER=$MAJOR_VER
      fi

      if [[ "$CHECK_VER" -lt 16 ]]; then
        echo "❌ Xcode 16+ required!"
        exit 1
      fi

      echo "✅ Using Xcode version $XCODE_VER (check $CHECK_VER)"

  - name: Setup Python 3.13
    uses: actions/setup-python@v5
    with:
      python-version: '3.13'

  - name: Verify Python framework symlink
    run: |
      FRAMEWORK_PATH="/Library/Frameworks/Python.framework/Versions/3.13/bin/python3.13"
      if [ ! -x "$FRAMEWORK_PATH" ]; then
        echo "❌ Expected Python 3.13 at $FRAMEWORK_PATH not found!"
        exit 1
      fi
      echo "✅ Python 3.13 found at $FRAMEWORK_PATH"

  - name: Prepare Python env
    run: |
      python3.13 --version
      pip3 install --upgrade pip
      pip3 install setuptools
      pip3 install --upgrade setuptools

  - name: Download CloverGnuBuildTools
    run: |
      mkdir -p toolchain/tools/download
      cd toolchain/tools/download
      curl -L -o CloverBuildTools.zip https://github.com/YBronst/CloverBuildUtilities/releases/download/V.1.0/CloverBuildTools.zip
      unzip CloverBuildTools.zip
      cp -r CloverBuildTools/* .
      rm -rf CloverBuildTools CloverBuildTools.zip

actions runs: CI #16 Artifact download URL: Artifact Clover-GCC-15.1.0-756b02c5.zip

I close the PR

@YBronst
Copy link
Contributor Author

YBronst commented Sep 25, 2025

I removed all the unnecessary block that I only needed to see the details.

@chris1111
Copy link
Contributor

chris1111 commented Sep 25, 2025

I removed all the unnecessary block that I only needed to see the details.

The Action Build is broken by this commits
because of this # Thats it no other file need to change

@YBronst
Copy link
Contributor Author

YBronst commented Sep 25, 2025

I made a completely clean commit, re-cloned the original repository, and added only the fixed files. No junk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants