configure: Modernize configure.ac a bit #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to make 2.71 happy. Also increase minimum version to 2.69 (10 years old version so should be compatible enough). Signed-off-by: Jan Friesse <[email protected]>
|
I’m afk, will be back on 6th August
… On 26.07.2022, at 17:03, Jan Friesse ***@***.***> wrote:
... to make 2.71 happy. Also increase minimum version to 2.69 (10 years
old version so should be compatible enough).
@dmuhamedagic Also during preparing this patch I've found that it is impossible to compile code when BUILD_TIMER_C is unset (so platform without clock_gettime). Fix shouldn't be so hard, but I'm wondering if it does make any sense to support such platforms (and have extra, probably untested ifdef)? Would you accept patch which would make clock_gettime required and remove ifdef with code for platforms without clock_gettime? It wouldn't be super huge code saver, but it removes some line (and - especially - (probably) untested ifdef part of code).
You can view, comment on, or merge this pull request online at:
#118
Commit Summary
86f0609 configure: Modernize configure.ac a bit
File Changes (1 file)
M configure.ac (17)
Patch Links:
https://github.com/ClusterLabs/booth/pull/118.patch
https://github.com/ClusterLabs/booth/pull/118.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
|
On Tue, Jul 26, 2022 at 08:03:18AM -0700, Jan Friesse wrote:
... to make 2.71 happy. Also increase minimum version to 2.69 (10 years
old version so should be compatible enough).
OK.
@dmuhamedagic Also during preparing this patch I've found that it is impossible to compile code when BUILD_TIMER_C is unset (so platform without clock_gettime). Fix shouldn't be so hard, but I'm wondering if it does make any sense to support such platforms (and have extra, probably untested ifdef)? Would you accept patch which would make clock_gettime required and remove ifdef with code for platforms without clock_gettime? It wouldn't be super huge code saver, but it removes some line (and - especially - (probably) untested ifdef part of code).
I suppose that we can do that. No idea which platforms don't
support clock_gettime, but I guess that there won't be many.
|
|
Thanks! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to make 2.71 happy. Also increase minimum version to 2.69 (10 years
old version so should be compatible enough).
@dmuhamedagic Also during preparing this patch I've found that it is impossible to compile code when BUILD_TIMER_C is unset (so platform without clock_gettime). Fix shouldn't be so hard, but I'm wondering if it does make any sense to support such platforms (and have extra, probably untested ifdef)? Would you accept patch which would make clock_gettime required and remove ifdef with code for platforms without clock_gettime? It wouldn't be super huge code saver, but it removes some lines (and - especially - (probably) untested ifdef part of code).