Skip to content

Maintainance cleanup #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jnpkrn wants to merge 16 commits into from
Closed

Maintainance cleanup #20

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4e4a3ec
build: s/CPPFLAGS/CFLAGS/ + use GLIB_LIB
jnpkrn Feb 17, 2016
056b9c9
maint: spec: SPDX license notation only for SUSE
jnpkrn Feb 17, 2016
e40d4a3
maint: spec: drop redundant, unused %check scriptlet
jnpkrn Feb 17, 2016
ebf53e3
maint: spec: get rid of redundant %clean section
jnpkrn Feb 17, 2016
ab5f397
maint: configure: drop useless AC_CHECK_LIB invocations
jnpkrn Feb 17, 2016
ceec5c2
maint: spec: use pkgconfig for glib-2.0
jnpkrn Feb 17, 2016
e030217
maint: configure: nicely formatted help/summary screens
jnpkrn Feb 17, 2016
2c22f54
maint: configure: --enable-resource-monitor no longer relevant
jnpkrn Feb 24, 2016
1319660
maint: build: allow requesting no HTML man + use in spec
jnpkrn Feb 24, 2016
5d2b6b3
Low: avoid using cl_log directly
jnpkrn Feb 17, 2016
1dcd750
Low: "char *" more string funcs friendly than unsigned variant
jnpkrn Feb 23, 2016
b8b9657
Low: attr: assert the string truncation will not occur
jnpkrn Feb 24, 2016
ce1effc
Low: make (a defensive) use of known static buffer sizes
jnpkrn Feb 24, 2016
89d9e06
Low: apparently static function should be marked so
jnpkrn Feb 24, 2016
8149495
Low: const-cast char arrays where suitable
jnpkrn Feb 23, 2016
9c7ccd2
Low: use unsigned int where suitable
jnpkrn Feb 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/attr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,11 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/

#include <assert.h>
#include <stdio.h>
#include <string.h>
#include "attr.h"
#include "booth.h"
#include "ticket.h"
#include "pacemaker.h"

Expand Down Expand Up @@ -274,8 +277,9 @@ int store_geo_attr(struct ticket_config *tk, const char *name, char *val, int no
if (!notime)
get_time(&a->update_ts);

assert(strnlen(name, BOOTH_NAME_LEN) < BOOTH_NAME_LEN);
Copy link

@dmuhamedagic dmuhamedagic Apr 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have booth continue to run, even with a truncated attribute name. iirc, this was not unpremeditated.

Copy link
Author

@jnpkrn jnpkrn Apr 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I understand that it might be too easy (accidentally or not) to push booth layer out of the function with a single crafted geo attribute in CIB/crm_ticket one-liner. So does turning that into warning sounds better? Then, we should likely warn also in case of trying to set/delete such a troublesome (too long in either name or value) attribute being provided by the user to geostore command.

Copy link

@dmuhamedagic dmuhamedagic Apr 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Tue, Apr 19, 2016 at 06:26:49AM -0700, Jan Pokorný wrote:

@@ -274,8 +277,9 @@ int store_geo_attr(struct ticket_config *tk, const char *name, char *val, int no
if (!notime)
get_time(&a->update_ts);

  • assert(strnlen(name, BOOTH_NAME_LEN) < BOOTH_NAME_LEN);

OK, I understand that it might be too easy (accidentally or not) to push booth layer out of the function with a single crafted geo attribute in CIB/crm_ticket one-liner. So does turning that into warning sounds better? Then, we should likely warn also in case of trying to set/delete such a troublesome (too long in either name or value) attribute being provided by the user to geostore command.

Yes, warning seems to be better.

g_hash_table_insert(tk->attr,
g_strndup(name, BOOTH_NAME_LEN), a);
g_strndup(name, BOOTH_NAME_LEN-1), a);

return 0;
}
Expand Down