Skip to content

Maintenance refresh, part 3: code cleanup #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jnpkrn wants to merge 8 commits into from
Closed

Maintenance refresh, part 3: code cleanup #30

jnpkrn wants to merge 8 commits into from

Conversation

@jnpkrn
Copy link

@jnpkrn jnpkrn commented Apr 22, 2016

Expects #29 merged.

@jnpkrn
Copy link
Author

jnpkrn commented Apr 22, 2016

Note that this PR is still unfinished, I am working towards handling
the limitations imposed with limited static buffers more gracefully
so at to be explicit about possible truncations.

@jnpkrn jnpkrn mentioned this pull request Apr 22, 2016
Closed
@jnpkrn
Copy link
Author

jnpkrn commented Apr 22, 2016

Ok, that's now done with 52f255a.

@jnpkrn jnpkrn mentioned this pull request Apr 26, 2016
Merged
jnpkrn added 8 commits April 26, 2016 16:27
@jnpkrn
Low: avoid using cl_log directly
e87007b
@jnpkrn
Low: apparently static function should be marked so
3686026
@jnpkrn
Low: use unsigned int where suitable
7f131cb 
Or more frankly, where compiler complains, which is a good
approximation.
@jnpkrn
Low: const-cast char arrays where suitable
552e06f 
Or more frankly, where compiler complains (which is a good
approximation) + human spotted eligible parts.

Also make cast from/to "xmlChar *" explicit.
@jnpkrn
Low: "char *" more string funcs friendly than unsigned variant
e6033cc 
Also make use of typedef'd boothc_site.
@jnpkrn
Low: make (a defensive) use of known static buffer sizes
1cee496 
Some cases might have still been omitted.
@jnpkrn
Low: drop unused inline function
4e76c65
@jnpkrn
Med: prevent possible truncation w/ invalid geoattrs in CIB
6bd9328 
Emit a warning so that there's a trace of such attributes being
intentionally omitted.
@jnpkrn
Copy link
Author

jnpkrn commented Apr 26, 2016

Rebased on current master.

@dmuhamedagic
Copy link

dmuhamedagic commented Apr 26, 2016

On Tue, Apr 26, 2016 at 07:32:19AM -0700, Jan Pokorný wrote:

Rebased on current master.

I did that on the command line, before merging.

Good work!

@dmuhamedagic
Copy link

dmuhamedagic commented Apr 26, 2016

Hmm, strange that this is not shown as merged.

@jnpkrn
Copy link
Author

jnpkrn commented Apr 26, 2016

NM, I see it merged: commit 0cd99ac.

I find it PITA to work with GH merge system at times, for instance
it cannot infer dependency/containment amongst the PRs, so the
unability to catch up with out-of-projected workflow comes as no
surprise.

@jnpkrn jnpkrn closed this Apr 26, 2016
@jnpkrn
Copy link
Author

jnpkrn commented Apr 26, 2016

And thanks for the reviews and merging.
Let me know what you think of cluster-glue opt-out PR (#22).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jnpkrn @dmuhamedagic