Skip to content

unit tests: making them passing #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmuhamedagic merged 4 commits into from
May 19, 2016
Merged

unit tests: making them passing #31

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e6846aa
test: fix failing test_a_few_trailing_whitespaces
jnpkrn Apr 27, 2016
14c17a4
test: adapt to libqb-based logging with lowercased priorities
jnpkrn Apr 27, 2016
4754bd5
test: booth cannot cope with <address>%<device> IPv6 addresses
jnpkrn Apr 27, 2016
c0b2b37
test: fix a typo in assertion violation message
jnpkrn Apr 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: fix failing test_a_few_trailing_whitespaces 
Original assertion tested the exact opposite to what is expected
(when daemon gets killed, lock/pid file should no longer exist).
  • Loading branch information
@jnpkrn
jnpkrn committed Apr 27, 2016
commit e6846aa10a64fdfb7f6c2b3a3dc63ccebb91a45d
2 changes: 1 addition & 1 deletion test/serverenv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def check_daemon_handling(self, runner, expected_daemon):
self.kill_pid(int(daemon_pid))
time.sleep(1)
daemon_pid = self.get_daemon_pid_from_lock_file(runner.lock_file)
self.assertTrue(daemon_pid is not None,
self.assertTrue(daemon_pid is None,
'bnc#749763: lock file should vanish after daemon is killed')

def get_daemon_pid_from_lock_file(self, lock_file):
Expand Down