Med-ranked fixes #36
Merged
Med-ranked fixes #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...instead of accidentally stealing variables from the outter, lexical scope, which only worked thanks to match on identifiers, and would get ultimately broken on renaming them in respective lexical scopes.
Note that such a case seems impossible but there may be other issues that will add up (see, e.g., reckless snprintf use pointed out with ClusterLabs/pacemaker#810, something should eventually be reflected here as well). Discovered-by: static analysis/Coverity
Otherwise, condition in booth_tcp_init (src/transport.c): if (get_local_id() < 0) return -1; could never be triggered. It should not be triggered anyway at the current state, but try to stay sane no matter what, especially if the issue was hidden in such a nasty way. Also note that using "int" should be pretty much fine as precautions are taken in add_site so as to keep MSB unset for site IDs in use, which is sufficient to distinguish them from a signalling negative value. Discovered-by: static analysis/Coverity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.