A few fixes to the build process #4
Conversation
|
Hi Florian, I'd like to merge these patches, could you rebase the patchset against latest upstream? Thanks, |
dpkg-shlibdeps reports boothd uses none of the symbols exported by libdl and librt. dpkg-shlibdeps: warning: dependency on libdl.so.2 could be avoided if "debian/booth/usr/sbin/boothd" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on librt.so.1 could be avoided if "debian/booth/usr/sbin/boothd" were not uselessly linked against it (they use none of its symbols).
Instead of hand-crafting a pkg-config check, just use the PKG_CHECK_MODULES autoconf macro.
AM_CPPFLAGS is preferred over INCLUDES: http://www.gnu.org/software/automake/manual/html_node/Program-Variables.html
Add an AC_CHECK_LIB test for cl_log, autoconf automatically adds this to LIBS. No need to explicitly specifiy -lplumbgpl. Fixes Debian build warning: dpkg-shlibdeps: warning: dependency on libplumbgpl.so.2 could be avoided if "debian/booth/usr/sbin/boothd" were not uselessly linked against it (they use none of its symbols).
glib2 is a compile-time dependency only, no need to link against it. Fixes Debian build warning: dpkg-shlibdeps: warning: dependency on libglib-2.0.so.0 could be avoided if "debian/booth/usr/sbin/boothd" were not uselessly linked against it (they use none of its symbols).
|
It would help if you publicly explained what upstream is. I had expected it to be ClusterLabs/booth; evidently it's really jjzhang/booth. I've rebased to that, although the patchset would have cleanly applied to jjzhang/booth as it was. |
|
Closing to issue a fresh pull req against jjzhang/booth. |
|
Sorry for the confusion. ClusterLabs/booth was forked from jjzhang/booth originally, for now I always update both of the repos together, keeping the two repos the same. It seems the original patchset cannot be merged is because another patch from Yuich was just merged. But I'm not sure if it is related to different repos you're using. Anyway, thanks for the rebasing;) |
2 participants
Jiaju,
please consider pulling these commits which fix a few minor build issues (all detected during Debian packaging). They're practically all cosmetic fixes.
Cheers,
Florian