High-ranked fixes #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the branching used accidentally incorrect (not even remotely related) condition. Issue introduced with partial refactoring/rewrite/extension: 9ca5e67
|
The issue got introduced much earlier, just got copied over in
the referenced commit. The reason this never turned into a bug
with consequences is probably that anyway a full packet would
always be read, so the "if" statement was basically equivalent to
(offset > 0). But, good catch!
|
Author
|
I rechecked and still think the issue got introduced as detailed in the Thanks! |
Author
|
(I meant to say that MTU or physical layer for the interconnect in general is pretty much environment specific, and that it used to work reliably is just a matter of typical parameters, such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.