Feature: make log contain source address of unknown site #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ensure the comment is not ending with a free-floating "a" particle.
First, no other invocation is performed with this extra check, and then, find_site_by_id itself would have triggered NULL pointer dereference by that point already.
So far, log would contain just the (reasonably unique) identifier of the astray originator, but it's hard or downright impossible to unambiguously recover the original address just with this piece of knowledge. Hence to allow for convenient tracking such cases down, log also the source address if possible. Technically, we are abusing the fact that said identifiers are supposed to be non-negative (most significant bit set to zero) while the proper OK state is indicated with zero and proper error condition mostly with negative integers. So these identifiers fit nicely into the positive integer area, except for: - zero identifier <-- we flip all the bits but MSB to 1 in this case - malformed identifiers with MSB=1 <-- we flip MSB to 0 Also, we make sure that remaining error conditions not following the rule and being indicated with positive integers are now indicated with negative ones. This convention is also mentioned in the function declaration's comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.